MM Ome tif support#564
Conversation
- Added CLI support for Micro-Manager acquired ome tif datasets: converts to .zarr and then proceeds to reconstruction. - Added GUI functionality to support ome-tif - Added metadata info next to dataset selector utilizing "iohub info" like functionality
Remove duplicate open_ome_zarr import, drop unused TransformationMeta and DTypeLike imports, and reflow long lines in get_dataset_info.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
==========================================
- Coverage 55.49% 52.45% -3.05%
==========================================
Files 62 62
Lines 11051 11654 +603
==========================================
- Hits 6133 6113 -20
- Misses 4918 5541 +623 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
talonchandler
left a comment
There was a problem hiding this comment.
Hi @amitabhverma, thanks for this iteration.
The main shape of this feature is correct, but much of what's here duplicates code that lives in iohub. I just pushed a feature/ometiff-input branch that refactors to show what a minimal version would look like. By reusing iohub and moving the switching in parsing.py, we reduce the feature diff to <50 lines.
Regarding pinned dependencies, let's figure this out with automated tests. In my example branch I added a test that checks a simple ome.tiff against the current pyproject.toml, and I couldn't reproduce the issues you mentioned. If you saw failures, can you share:
- the traceback,
- the iohub, tifffile, zarr versions in the failing environment,
- the path/dataset that triggered the issue, and
- ideally, a failing automated test that reproduces the problem.
If we need to pin versions, this PR should include a change to pyproject.toml and an automated test that fails without the pin.
- merged changes from branch https://github.com/mehta-lab/waveorder/tree/feature/ometiff-input - discarded auto-populate - minor additions to docs
talonchandler
left a comment
There was a problem hiding this comment.
Final fixes made together. Looks great! Thanks @amitabhverma
- auto-populates YX and Z pixel sizes from dataset metadata
|
Couple of points I forgot to ask/share on Friday.
|
|
Thanks Amit...following up with a summary of our chat just now:
|

Incorporated changes based on comments from previous pull request #527