Remove obsolete macros and deprecated versions - #4467
Merged
Conversation
hamishwillee
requested review from
a team and
chrisdavidmills
and removed request for
a team
April 26, 2021 02:32
hamishwillee
commented
Apr 26, 2021
| <p><code><a href="https://github.com/mdn/yari/tree/master/kumascript/macros/deprecated_inline.ejs">deprecated_inline</a></code> inserts an in-line deprecated mark to discourage the use of an API that is officially deprecated. <strong>Note:</strong> "Deprecated" means that the item should no longer be used, but still functions. If you mean that it no longer works at all, use the term "obsolete."</p> | ||
|
|
||
| <p>Don't use the parameter in any browser-agnostic area (HTML, APIs, JS, CSS, …).</p> | ||
| <p><code><a href="https://github.com/mdn/yari/tree/master/kumascript/macros/deprecated_inline.ejs">deprecated_inline</a></code> inserts an in-line deprecated mark ({{Deprecated_Inline}}) to discourage the use of an API that is officially deprecated (or has been removed).</p> |
Collaborator
Author
There was a problem hiding this comment.
This page has the main changes - essentially removing the things we don' support from the user guide.
Contributor
chrisdavidmills
approved these changes
Apr 26, 2021
chrisdavidmills
left a comment
Contributor
There was a problem hiding this comment.
LGTM; thanks @hamishwillee !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to @chrisdavidmills MDN does not used the argument in deprecated macro and should not use the obsolete macros (header or inline) - see #4226 (comment)
What this does is remove mention of the version argument from deprecated, and mention of the obsolete macro. I have done a very small subset of the cases too. This gives people a chance to complain before I do a PR with all the remaining fixes.
FYI @chrisdavidmills @sideshowbarker @Elchi3