Update fetchPriority to match the final spec - #24595
Merged
Merged
Conversation
pmeenan
requested review from
a team,
bsmth,
estelle and
sideshowbarker
and removed request for
a team
February 19, 2023 17:42
Contributor
Preview URLs (6 pages)Flaws (2)Note! 4 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
External URLs (7)URL:
URL:
|
sideshowbarker
approved these changes
Feb 20, 2023
hamishwillee
pushed a commit
that referenced
this pull request
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the
fetchpriorityHTML attribute andpriorityfetch option to match the final spec. This is a cleaner version of this PR that had rebase issues.Motivation
The Priority Hints spec was merged into the HTML and fetch specs, obsoleting the original spec.
Additional details
Here is the HTML spec PR and the Fetch spec PR.
Summarized changes:
fetchPriorityattribute (was never implemented anywhere).priorityattribute from the Request interface (it is only settable through options).priorityoption as part of creating a fetch request and constructing a request was updated.importanceattribute was updated.Related issues and pull requests
Fixes #24519