Feat/on left swipe delete from queue - #2328
Open
laoluogun wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I saw people mention wanting to be able to swipe to the left to delete a song from the queue, so I added it using the same style as swiping to the right to add a song to the queue.
Note 1: The videos display the add to queue button functionality still working.
Note 2: I moved
modifier = Modifier.align(Alignment.CenterStart)inside to crossfade because when I tried following the original pattern, but instead with Alignment.CenterEnd, to place the delete icon on the righthand side, it would stay on the left. Moving it solved this error. Everything else is in the same pattern as the original swipe logic.Note 3: Delete button is red but could be changed to same color scheme as the queue button for consistency.
Android:
Android.Both.Swipes.mp4
Desktop:
Desktop.Both.Swipes.mp4
Illustrating Alignment.CenterEnd when placed within the Box and not Crossfade:
