feat(client): Support for RTC transports discovery#6789
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6789 +/- ##
==========================================
- Coverage 90.02% 90.01% -0.01%
==========================================
Files 405 405
Lines 113627 113746 +119
Branches 113627 113746 +119
==========================================
+ Hits 102290 102386 +96
- Misses 7463 7476 +13
- Partials 3874 3884 +10 ☔ View full report in Codecov by Harness. |
810fa7b to
4845b3f
Compare
jmartinesp
left a comment
There was a problem hiding this comment.
LGTM, just wondering if it's a good idea to rename the existing method if it's being deprecated anyway. I guess it'll mean a migration will be needed and it will force clients to notice the replacement.
Maybe I can keep the old name like that? #[deprecated = "Use `Client::rtc_transports` instead"]
pub async fn rtc_foci(&self) -> HttpResult<Vec<RtcTransport>> {
self.well_known_rtc_transports()
} |
RTC transport discovery has now a new authenticated end-point on the homeserver
GET /_matrix/client/v1/rtc/transportsThis PR add supports for that via a new client API
Client::rtc_transports, it uses the existing cache mecanism used by similar APIs (well-known, supported_version). I used a similar pattern.The old
rtc_fociendpoint has been renamed towellknown_rtc_transportand should only be used as fallback if new endpoint is not supportedSigned-off-by: