Skip to content

RTL support.#411

Merged
mathuo merged 1 commit into
mathuo:388-rtl-support-1from
NaNgets:388-rtl-support-gpgsigned
Dec 28, 2023
Merged

RTL support.#411
mathuo merged 1 commit into
mathuo:388-rtl-support-1from
NaNgets:388-rtl-support-gpgsigned

Conversation

@NaNgets

@NaNgets NaNgets commented Dec 28, 2023

Copy link
Copy Markdown
Contributor

Related #388

I have checked manually that it works as much as possible,
Please let me know if I've missed something or need to add\change something.

@mathuo Thank you very much.

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0bf9c63:

Sandbox Source
constraints-dockview Configuration
customheader-dockview Configuration
demo-dockview Configuration
dnd-dockview Configuration
dockview-app Configuration
editor-gridview Configuration
events-dockview Configuration
externaldnd-dockview Configuration
floatinggroup-dockview Configuration
fullwidthtab-dockview Configuration
headeractions-dockview Configuration
iframe-dockview Configuration
keyboard-dockview Configuration
layout-dockview Configuration
lockedgroup-dockview Configuration
nativeapp-dockview Configuration
nested-dockview Configuration
rendering-dockview Configuration
rendermode-dockview Configuration
resize-dockview Configuration
resizecontainer-dockview Configuration
simple-dockview Configuration
simple-gridview Configuration
simple-paneview Configuration

@mathuo

mathuo commented Dec 28, 2023

Copy link
Copy Markdown
Owner

Related #388

I have checked manually that it works as much as possible, Please let me know if I've missed something or need to add\change something.

@mathuo Thank you very much.

So fast! I appreicate you taking the time to work on this.

Could you raise a PR vs this branch 388-rtl-support-1? Doing this I can merge that code from your fork back onto a branch under this repo which will allow me to publish an experimental build without having to immediately merge it to master since I assume having an experimental build for this may be useful for people to try out. It'll also trigger some additional automated checks that seem to only work on branches belonging directly to the repo rather than forks.

After checking etc I will then merge that branch into master.

@NaNgets NaNgets changed the base branch from master to 388-rtl-support-1 December 28, 2023 21:32
@NaNgets

NaNgets commented Dec 28, 2023

Copy link
Copy Markdown
Contributor Author

Sure, done.
Thank you very much, if there's anything else I can help with - please let me know :)

@mathuo mathuo merged commit c2d65db into mathuo:388-rtl-support-1 Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants