Skip to content
This repository was archived by the owner on Jul 14, 2025. It is now read-only.

Add prefix to mbtiles, return 204 on no tile - #88

Merged
daliborjanak merged 1 commit into
maptiler:masterfrom
mtfurlan:master
Aug 29, 2016
Merged

Add prefix to mbtiles, return 204 on no tile#88
daliborjanak merged 1 commit into
maptiler:masterfrom
mtfurlan:master

Conversation

@mtfurlan

Copy link
Copy Markdown

This adds a configuration option for a prefix to the mbtiles, so you can
store the tiles in other locations.

It also changes the no tile found 404 to a 204, as the mapbox team will
be doing:
mapbox/mapbox-gl-js#1800 (comment)

This adds a configuration option for a prefix to the mbtiles, so you can
store the tiles in other locations.

It also changes the no tile found 404 to a 204, as the mapbox team will
be doing:
mapbox/mapbox-gl-js#1800 (comment)
@daliborjanak

daliborjanak commented Aug 29, 2016

Copy link
Copy Markdown
Collaborator

Looks good. Thanks, but I would like to rename the variable mbtilesPrefix to something better. We are planning to add geopackage support in next days so it could be something like dataPath, dataSource or dataDir. What do you think?

@mtfurlan

Copy link
Copy Markdown
Author

I would vote for dataSource, or maybe dataDir.

@klokan

klokan commented Aug 29, 2016

Copy link
Copy Markdown
Member

In our TileServer GL it is called root path - see JSON config at http://tileserver.readthedocs.io/en/latest/config.html

@daliborjanak

Copy link
Copy Markdown
Collaborator

I'm prefering data*. Root is often used as root of an app. But this variable as to be used also for folder structures - with serving without htaccess...

@klokan

klokan commented Aug 29, 2016

Copy link
Copy Markdown
Member

dataRoot or dataPath?

@mtfurlan

Copy link
Copy Markdown
Author

dataRoot would work, it's still clear as to what it does.

@daliborjanak
daliborjanak merged commit 682a9ee into maptiler:master Aug 29, 2016
@mtfurlan

Copy link
Copy Markdown
Author

It's still mbtilesPrefix?

@daliborjanak

Copy link
Copy Markdown
Collaborator

2ead30d

@mtfurlan

Copy link
Copy Markdown
Author

Fair enough.
Many thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants