Accessibility improvements#250
Closed
maxx1128 wants to merge 2 commits into
Closed
Conversation
maxx1128
force-pushed
the
notification-accessibility-improvements
branch
from
November 15, 2019 16:12
257af89 to
0023d41
Compare
maxx1128
force-pushed
the
notification-accessibility-improvements
branch
from
October 5, 2020 18:37
0023d41 to
f4e5154
Compare
Author
|
Just rebased this on top of the most recent version of the dependency. I agree with @hergaiety that it'd be a big time-saver to just get this merged into the main repo. |
pichfl
added a commit
to pichfl/ember-cli-notifications
that referenced
this pull request
Dec 15, 2021
Partially replaces mansona#250
pichfl
added a commit
to pichfl/ember-cli-notifications
that referenced
this pull request
Dec 15, 2021
* Better variables * Slightly more readable colors * Support `prefers-reduced-motion` and reduces motion in Ember tests by default * Added proper ARIA role to notification * Partially replaces mansona#250
pichfl
added a commit
to pichfl/ember-cli-notifications
that referenced
this pull request
Dec 15, 2021
Partially replaces mansona#250
pichfl
added a commit
to pichfl/ember-cli-notifications
that referenced
this pull request
Dec 15, 2021
* Better variables * Slightly more readable colors * Support `prefers-reduced-motion` and reduces motion in Ember tests by default * Added proper ARIA role to notification * Partially replaces mansona#250
pichfl
added a commit
to pichfl/ember-cli-notifications
that referenced
this pull request
Dec 15, 2021
* Better variables * Slightly more readable colors * Support `prefers-reduced-motion` and reduces motion in Ember tests by default * Added proper ARIA role to notification * Partially replaces mansona#250
pichfl
added a commit
to pichfl/ember-cli-notifications
that referenced
this pull request
Jun 8, 2022
* Better variables * Slightly more readable colors * Support `prefers-reduced-motion` and reduces motion in Ember tests by default * Added proper ARIA role to notification * Partially replaces mansona#250
pichfl
added a commit
to pichfl/ember-cli-notifications
that referenced
this pull request
Jun 8, 2022
Partially replaces mansona#250
Author
|
This has been ignored for about five years, going to close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes for making the notifications more accessible.