[MSC] Implement The Fantasticar - #15213
Merged
xenohedron merged 7 commits intoJun 27, 2026
Merged
Conversation
muz
reviewed
Jun 11, 2026
muz
left a comment
muz
left a comment
Contributor
There was a problem hiding this comment.
Couple of minor comments but broadly looking good so far
xenohedron
self-requested a review
June 11, 2026 16:41
lilacLunatic
commented
Jun 11, 2026
| StaticFilters.FILTER_SPELL_NON_CREATURE.match(game.getSpell(event.getTargetId()), game) && | ||
| watcher.getSpellsCastThisTurn(this.getControllerId()) | ||
| .stream() | ||
| .filter(spell -> !spell.isCreature(null)) |
Contributor
Author
There was a problem hiding this comment.
N.B. This call to isCreature() uses null rather than game in order to circumvent an issue with noncreature spells that became a creature on the battlefield later in the turn not counting towards the trigger. That is a bug, and is further discussed in the Discord server (will edit to link to the corresponding issue once it's up).
muz
reviewed
Jun 12, 2026
muz
reviewed
Jun 12, 2026
Co-authored-by: Muz <muz@users.noreply.github.com>
lilacLunatic
force-pushed
the
card/msc_the_fantasticar
branch
from
June 13, 2026 21:07
9d21487 to
e3f8450
Compare
spells count trigger if it became a creature on the battlefield, by means of a custom watcher
xenohedron
approved these changes
Jun 25, 2026
xenohedron
left a comment
xenohedron
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution!
(When I have time I'll write a followup issue, but this card is good to go as is.)
muz
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.