fix(find): detect Web Enrollment on HTTP 200/403 responses - #377
Open
alham-rizvi wants to merge 1 commit into
Open
alham-rizvi wants to merge 1 commit into
alham-rizvi wants to merge 1 commit into
Conversation
Previously, check_web_enrollment() only treated an HTTP 401 response as evidence that the /certsrv/ endpoint was enabled. Some AD CS configurations return 200 (anonymous browsing permitted, authentication only required for enrollment) or 403, which caused a false negative where Web Enrollment was incorrectly reported as disabled. - Treat 403 Forbidden as enabled (service running, access denied). - Treat 200 as enabled only when the body looks like the Certificate Services web interface (contains "certsrv" or "certificate services"), to avoid false positives from unrelated web applications. - 401 behavior is unchanged. Fixes ly4k#367
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, check_web_enrollment() only treated an HTTP 401 response as evidence that the /certsrv/ endpoint was enabled. Some AD CS configurations return 200 (anonymous browsing permitted, authentication only required for enrollment) or 403, which caused a false negative where Web Enrollment was incorrectly reported as disabled.
Fixes #367