Pr code - #376
Closed
sheepiroth1 wants to merge 2 commits into
Closed
Pr code#376sheepiroth1 wants to merge 2 commits into
sheepiroth1 wants to merge 2 commits into
Conversation
Some AD CS certificate templates require ECDSA_P256 (or ECDH_P256/P384/P521)
private keys via the msPKI-RA-Application-Policies attribute. Previously,
Certipy generated RSA keys unconditionally and the CA rejected such requests
with CERTSRV_E_BAD_REQUESTSTATUS (0x80094003).
This adds:
- generate_ec_key(curve_name) - creates an EC private key on the requested
NIST curve (P256, P384, or P521).
- sign_csr_data(...) - key-type-aware CSR signer (RSA-PKCS1v1.5 or ECDSA).
- Two new CLI arguments on certipy req:
-key-type {rsa,ec,ecdsa,ecdh} default: rsa
-curve {P256,P384,P521} default: P256
- The CSR signature_algorithm OID is now selected based on the key type
(sha256_ecdsa for EC keys, sha256_rsa for RSA keys).
certipy auth (PKINIT) is not yet updated to consume EC private keys;
-ldap-shell is a working post-issuance alternative. A follow-up PR can
extend PKINIT if there is interest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.