Protection from passing wrong symbols/strings to enums.

[mainameiz]

First of all, thank you for writing such a good gem. :-)

class Model < AR
  as_enum :state, {
    accept: 0,
    reject: 1
  }
end

Model.states[:wrong_state] => nil

It seems to be better to raise an exception in such cases.

[matthewrudy]

maybe we just want Model.states.fetch(:wrong_state)
and behave like Hash#fetch

[lwe]

You can use the whiny accessor, that works like that

class User < ActiveRecord::Base
  as_enum :gender, %w{male female}, accessor: :whiny
end
User.new(gender: "dunno") # => raises ArgumentError

[lwe]

and you are welcome :)

[mainameiz]

@lwe Yes, whiny accessor works great, but image we write a scope

-> { where(state_cd: self.states[:wrong_state]) }

It will silently paste nil in sql query. To protect from such cases I suggest to raise an error or to implement #fetch method as @matthewrudy suggests. I cant image situations where it can be prefered to return nil for not existing enums.

Thank you for writing such a good gem :-)

[lwe]

Ah, now I get it, sorry. Yes, please, feel free to provide a pull request with a fetch implementation, would gladly accept it.

[mainameiz]

@lwe ok!

[mainameiz]

Done! #104