[clang][bytecode] long double on arm64 darwin is 8 bytes (NFC)#209930
Merged
Conversation
This test was failing on arm64 darwin targets. Generalise the #if so that the win32 branch is also taken by arm64 darwin. rdar://182340494
|
@llvm/pr-subscribers-clang Author: Henrik G. Olsson (hnrklssn) ChangesThis test was failing on arm64 darwin targets. Generalise the #if so that the win32 branch is also taken by arm64 darwin. rdar://182340494 Full diff: https://github.com/llvm/llvm-project/pull/209930.diff 1 Files Affected:
diff --git a/clang/test/AST/ByteCode/builtin-object-size.cpp b/clang/test/AST/ByteCode/builtin-object-size.cpp
index 69534025fe3f4..31b95990f658c 100644
--- a/clang/test/AST/ByteCode/builtin-object-size.cpp
+++ b/clang/test/AST/ByteCode/builtin-object-size.cpp
@@ -61,7 +61,7 @@ namespace Padding {
void foo() {
LongDouble3Vec v1, v2;
#if __SIZEOF_SIZE_T__ == 8
-#if !defined(_WIN32)
+#if __SIZEOF_LONG_DOUBLE__ == 16
static_assert(__builtin_object_size(&v1, 0) == 64);
#else
static_assert(__builtin_object_size(&v1, 0) == 32);
|
dyung
approved these changes
Jul 16, 2026
dyung
left a comment
Contributor
There was a problem hiding this comment.
lgtm and I think this is more reliable. Thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was failing on arm64 darwin targets. Generalise the #if so that the win32 branch is also taken by arm64 darwin.
rdar://182340494