chore: upkeep follow-ups (PHPUnit stubs, vite target, repo cleanup)#140
Merged
Conversation
This commit deletes three legacy files: .cursorrules, contributing.md, and env. The deletions remove outdated scaffolding and example settings that no longer reflect the project structure, reducing confusion for new contributors and CI checks. There are no functional changes to the application; if onboarding or environment setup is needed, it should be provided through up-to-date documentation or example configurations in current docs.
Converts all test doubles from MockObject-based mocks to Stub instances and updates related type hints and mock creation calls to simplify dependency injection in tests. Upgrades PHPUnit configuration to v13 by updating the noNamespaceSchemaLocation and adapting tests to the new Stub usage. Aligns project tooling with newer environments by enforcing Node >=20.19 in package.json and configuring vite to target ES2020 for broader browser compatibility.
Adds a new .phpactor.json to enable language_server_phpstan and language_server_php_cs_fixer, tightening IDE diagnostics and automatic formatting for PHP. Deletes docs/tasks.md, removing the large pre-upgrade task list from the repository. This config change improves developer experience by enabling static analysis and fixers in the editor, while the doc removal should be complemented by a replacement or migration plan for task tracking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createMock()tocreateStub()across the test suitees2020target and Node engine constraintenv,.cursorrules, rootcontributing.md) and empty Vue directoriesChanges
Test cleanup
createMock()→createStub()for mocks that use no expectationscreateMock()→createStub()for mocks that use no expectationscreateMock()intentionally retained because it uses->expects()createMock()→createStub()for mocks that use no expectations12.5to13.1Build / config
build.target: 'es2020'explicitly (Vite 7+ default changed to "baseline-widely-available")"engines": { "node": ">=20.19" }to document the minimum Node requirementRepo cleanup
.env.example)docs/contributing.md)Editor tooling
Docs
Verification
All of the following were run clean during development:
composer test— full test suite passes, 0 deprecation noticescomposer analyse— PHPStan passes at configured levelpnpm build— production assets build without errorspnpm dev— dev server starts cleanlycomposer audit— no known security vulnerabilitiespnpm audit— no known security vulnerabilities