Handle data track SID reassignment#1228
Merged
Merged
Conversation
Contributor
ChangesetThe following package versions will be affected by this PR:
|
![devin-ai-integration[bot]](https://avatars.github.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
stephen-derosa
approved these changes
Jul 8, 2026
stephen-derosa
left a comment
stephen-derosa
left a comment
Contributor
There was a problem hiding this comment.
lgtm -- nice tests!
1egoman
approved these changes
Jul 9, 2026
1egoman
left a comment
1egoman
left a comment
Contributor
There was a problem hiding this comment.
Generally makes sense to me!
| let Some(descriptor) = self.descriptors.remove(&old_sid) else { | ||
| return false; | ||
| }; | ||
| *descriptor.info.sid.write().unwrap() = new_sid.clone(); |
Contributor
There was a problem hiding this comment.
Just want to call out, in case this makes you more confident that this is correct - I did something very similar to this in a recent node sdk change (also ported this to python) for regular tracks to ensure that upon republish just the sid is updated: https://github.com/livekit/node-sdks/blob/e4a769c9717e6657f03ef44528640c2fb74973a8/packages/livekit-rtc/src/room.ts#L607-L615
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes BOT-456