This repository was archived by the owner on Apr 16, 2026. It is now read-only.
Change to secure publishing for PyPI#388
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
=======================================
Coverage 63.79% 63.79%
=======================================
Files 63 63
Lines 8946 8946
Branches 2587 2587
=======================================
Hits 5707 5707
Misses 2633 2633
Partials 606 606 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dalito
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the PyPI publishing configuration to use trusted publishing in accordance with the official PyPI documentation. Key changes include:
- Un-commenting and updating the trusted publishing configuration (environment and permissions).
- Updating the GitHub action version from "v1.12" to the full valid tag "v1.12.4".
- Activating the verbose mode on publish while removing the obsolete password parameter.
sierra-moxon
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upstream_repo: dalito/linkml
upstream_branch: issue2578-fix-uri-in-snapshot
Requires changing the configuration on PyPI. It is important to use the same environment name "pypi-release" (this name is different from some screenshots in the docs).
The upload-failure for 1.9.2-rc1 was most probably only caused by specifying the used action as
pypa/gh-action-pypi-publish@v1.12. The problem is that "1.12" is not a valid tag and so the action could not be downloaded/installed. In the gh-action-pypi-publish repository they only tag full versions "1.12.4" but not the minor versions without patch level "1.12". I changed this PR to use the full version.