This repository was archived by the owner on Apr 16, 2026. It is now read-only.
Add action to test with upstream linkml#316
Merged
Merged
Conversation
don't specify linkml-runtime repository so it works on pull requests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
=======================================
Coverage 62.70% 62.70%
=======================================
Files 63 63
Lines 8580 8580
Branches 2444 2444
=======================================
Hits 5380 5380
Misses 2583 2583
Partials 617 617 ☔ View full report in Codecov by Sentry. |
cmungall
approved these changes
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: linkml/linkml#1749
This PR adds an action to run the linkml tests against the current version of linkml-runtime.
This action runs after an approving review has been received, and can also be run manually. This is because this is a relatively expensive test, and should only be run after the content of a PR has been approved to check whether any modifications will need to be made upstream to accommodate it.
If this is accepted, in order for it to be protective we probably need to also add a branch protection rule that prevents pull requests from being merged until this action has passed. otherwise the temptation might be to approve a PR and then immediately merge it, since the action will run only then.
As with all github actions things, i am actually not sure it will do exactly what i think it will until i see it run, so this might require a little debugging, but anyway it should help out with the perennial need to manually run linkml tests against linkml-runtime and make it a bit easier for this repo to be developed safely
differences from linkml
main.yamlI swapped out the default being pydantic 1 to pydantic 2, since 1 is soon to be deprecated, and also added testing for 3.11
dynamic versioning
This PR ALSO adds dynamic versioning to this repo exactly as is done in
linkml- i am not sure why that wasn't present before, but it seems like it should be? currently the version in the repo is literally0.0.0and that prevents us from checking that the correctlinkml-runtimeversion is installed during this action