Guard Triton launches by tensor device#1304
Open
kashif wants to merge 2 commits into
Open
Conversation
kashif
marked this pull request as ready for review
July 16, 2026 13:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1303.
Some Triton launches can receive tensors on a non-current GPU, for example under
device_map="auto". Triton uses the active device for launch and compile state, so the launch needs to enter the input tensor's device context.This adds a small shared
device_contexthelper and applies it directly around the RMSNorm, SwiGLU, and GeGLU launches.This follows the same pattern as huggingface/kernels-community#1029.
Checks:
make checkstylepython -m py_compile src/liger_kernel/ops/utils.py src/liger_kernel/ops/rms_norm.py src/liger_kernel/ops/swiglu.py src/liger_kernel/ops/geglu.pygit diff --check