LCORE-3141: Phone make targets

[tisnik]

Description

LCORE-3141: Phone make targets

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement
• Benchmarks improvement

Tools used to create PR

• Assisted-by: N/A
• Generated by: N/A

Related Tickets & Documents

• Related Issue #LCORE-3141

Summary by CodeRabbit

• Chores
  • Added model documentation generation targets to the build configuration.
  • Improved support for generating request, response, conversation, agent, and common model documentation.

[coderabbitai]

Walkthrough

The Makefile adds seven documentation model JSON generation targets to .PHONY and keeps docs/models/database.svg in the declaration.

Changes

Model generation targets

Layer / File(s)	Summary
Declare model generation targets Makefile	The .PHONY declaration now includes seven model JSON targets and the existing database SVG target.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• lightspeed-core/lightspeed-stack#2225: Updates related PlantUML and SVG model targets in the same docs/models build system.

Suggested reviewers: anik120, are-ces, asimurka

🚥 Pre-merge checks | ✅ 5 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title references a ticket (LCORE-3141) but does not clearly describe what changes were made. The phrase 'Phone make targets' is vague and does not convey the actual change of adding phony targets to the Makefile.	Use a clearer title such as 'LCORE-3141: Add phony targets for model JSON generation' to explicitly state what was added to the Makefile.
Security And Secret Handling	❓ Inconclusive	Custom check execution failed before a final verdict was produced.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity	✅ Passed	Only Makefile .PHONY entries changed; no new algorithms, loops, API/DB calls, list operations, caches, or unbounded data structures were added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

✨ Simplify code

• Create PR with simplified code

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Makefile`:
- Around line 36-43: Remove the seven JSON artifact targets from the .PHONY
declaration in the Makefile. Keep the existing recipes for
docs/models/database.svg and the JSON files as regular file targets so make can
skip regeneration when each target is current.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3392e7ac-09c0-4eea-b548-b68611940c0e

📥 Commits

Reviewing files that changed from the base of the PR and between 690d37b and 763c688.

📒 Files selected for processing (1)

• Makefile

📜 Review details

⏰ Context from checks skipped due to timeout. (11)

• GitHub Check: build-pr
• GitHub Check: integration_tests (3.13)
• GitHub Check: integration_tests (3.12)
• GitHub Check: E2E: server mode / ci / group 3
• GitHub Check: E2E: server mode / ci / group 2
• GitHub Check: E2E: server mode / ci / group 1
• GitHub Check: E2E: library mode / ci / group 1
• GitHub Check: E2E: library mode / ci / group 3
• GitHub Check: E2E: library mode / ci / group 2
• GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-7-on-pull-request
• GitHub Check: E2E Tests for Lightspeed Evaluation job

🧰 Additional context used

📓 Path-based instructions (1)

**/*

📄 CodeRabbit inference engine (Custom checks)

**/*: Flag meaningful O(n^2)+ algorithms on non-trivial inputs, including handlers and Kubernetes list operations.
Flag N+1 patterns that list items and then query once per item, including Kubernetes API and database access.
Flag expensive work inside loops, including API calls, JSON parsing, and regex compilation.
Flag unbounded growth in caches, watchers, or buffers when eviction or limits are missing.
Flag missing pagination or limits on list operations and API endpoints.
Flag secrets or tokens logged in plaintext or hardcoded in source.
Flag API endpoints missing authentication or authorization.
Flag injection vulnerabilities, including SQL injection, command injection, and path traversal.
Flag sensitive data leaked in API responses, WebSocket messages, or logs.
Flag Kubernetes Secrets and Red Hat secrets missing OwnerReferences.

Files:

• Makefile

[coderabbitai]

🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win

Real file-producing targets should not be phony.

These seven targets each produce a real, named file: the recipes at Line 243-269 run uv run src/lightspeed_stack.py --dump-models-group <group> and then mv <group>.json $@ to create the target file. Declaring a target phony makes make run its recipe every time, regardless of whether the file exists or is current. Adding these targets to .PHONY removes the incremental-build benefit, so make regenerates every JSON artifact on every invocation, even when nothing changed.

Keep these targets as regular file targets. Do not add them to .PHONY.

♻️ Proposed fix

 	docs/models/common.svg \
 	docs/models/database.svg \
-	docs/models/requests.json \
-	docs/models/conversation_summary.json \
-	docs/models/successful_responses.json \
-	docs/models/error_responses.json \
-	docs/models/common.json \
-	docs/models/agents.json \
-	docs/models/common_responses.json
+	docs/models

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	docs/models/database.svg \
	docs/models/requests.json \
	docs/models/conversation_summary.json \
	docs/models/successful_responses.json \
	docs/models/error_responses.json \
	docs/models/common.json \
	docs/models/agents.json \
	docs/models/common_responses.json
	docs/models/common.svg \
	docs/models/database.svg \
	docs/models

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Makefile` around lines 36 - 43, Remove the seven JSON artifact targets from
the .PHONY declaration in the Makefile. Keep the existing recipes for
docs/models/database.svg and the JSON files as regular file targets so make can
skip regeneration when each target is current.