-
Notifications
You must be signed in to change notification settings - Fork 98
LCORE- Update checkout action #2074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,7 @@ jobs: | |
| # qemu is required for arm64 builds | ||
| sudo apt install -y buildah qemu-user-static | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@v7 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win Version bump is correct; consider pinning to a commit SHA. Bump to 🔒 Suggested hardening- uses: actions/checkout@v7
+ uses: actions/checkout@a1caf0398a3f77c5db1a91c264eb1f6a0cb0e4d6 # v7.0.0Please verify the exact commit SHA for 🧰 Tools🪛 zizmor (1.26.1)[error] 28-28: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
| with: | ||
| # Fetch submodules (required for lightspeed-providers) | ||
| submodules: 'recursive' | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,7 @@ jobs: | |
| # qemu is required for arm64 builds | ||
| sudo apt install -y buildah qemu-user-static | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@v7 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win Version bump is correct; same unpinned-ref concern as Consistent with the sibling workflow's checkout step; consider pinning to a SHA to satisfy the blanket unpinned-uses policy flagged by zizmor. 🧰 Tools🪛 zizmor (1.26.1)[error] 26-26: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
| with: | ||
| # Fetch submodules (required for lightspeed-providers) | ||
| submodules: 'recursive' | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ jobs: | |
| contents: read | ||
| pull-requests: read | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win Version bump is correct; same pinning/persist-credentials gaps as Same pattern as 🧰 Tools🪛 zizmor (1.26.1)[warning] 14-14: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) [error] 14-14: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v5 | ||
| with: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,7 @@ jobs: | |
| contents: read | ||
| pull-requests: read | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "Workflow excerpt:"
sed -n '1,80p' .github/workflows/openapi_spectral.yaml | cat -n
echo
echo "Search for other checkout references:"
rg -n "actions/checkout@" .github/workflows -nRepository: lightspeed-core/lightspeed-stack Length of output: 3738 Pin
🧰 Tools🪛 zizmor (1.26.1)[warning] 18-18: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) [error] 18-18: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v5 | ||
| with: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ jobs: | |
| contents: read | ||
| pull-requests: read | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: git ls-files .github/workflows && printf '\n---\n' && rg -n "uses:\s*actions/checkout@|uses:\s*.*`@v`[0-9]+" .github/workflows -nRepository: lightspeed-core/lightspeed-stack Length of output: 4367 🏁 Script executed: cat -n .github/workflows/outdated_dependencies.yaml | sed -n '1,40p'Repository: lightspeed-core/lightspeed-stack Length of output: 802 Pin the external actions in this workflow. 🧰 Tools🪛 zizmor (1.26.1)[warning] 14-14: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) [error] 14-14: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v5 | ||
| with: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ jobs: | |
| contents: read | ||
| pull-requests: read | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: git ls-files .github/workflows/pydocstyle.yaml README.md .github/workflowsRepository: lightspeed-core/lightspeed-stack Length of output: 986 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== pydocstyle workflow =="
cat -n .github/workflows/pydocstyle.yaml | sed -n '1,120p'
echo
echo "== pinning guidance search =="
rg -n --hidden --glob '!**/.git/**' -e 'pin|SHA|checkout@v|actions/checkout' README.md .github/workflows .github 2>/dev/null || trueRepository: lightspeed-core/lightspeed-stack Length of output: 5014 🌐 Web query:
💡 Result: The actions/checkout v7 release was officially published on June 18, 2026, under the version tag v7.0.0 [1][2][3]. Key details regarding the v7 release include: - General Availability: The release was made generally available on June 18, 2026 [3]. - Security Improvements: A primary feature of v7 is improved security for workflows using pull_request_target or workflow_run triggers [3][4]. By default, v7 refuses to check out code from fork pull requests in these scenarios to prevent security vulnerabilities, such as "pwn request" attacks [3][4]. Users who require this functionality can opt in by setting the new input allow-unsafe-pr-checkout: true [4]. - Technical Updates: The action was migrated to ESM (ECMAScript Modules) to support newer versions of the Citations:
Pin 🧰 Tools🪛 zizmor (1.26.1)[warning] 14-14: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) [error] 14-14: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v5 | ||
| with: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ jobs: | |
| pull-requests: read | ||
| name: "Pylinter" | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
# Inspect the workflow and any repository guidance about pinning actions.
git ls-files .github/workflows/pylint.yaml README.md .github | sed -n '1,120p'
printf '\n--- pylint workflow ---\n'
cat -n .github/workflows/pylint.yaml
printf '\n--- search for action pinning guidance ---\n'
rg -n --hidden --glob '!.git' -e 'pin(ning)?' -e 'actions/checkout@' -e 'commit SHA' -e 'SHA' -e 'security policy' .github README.md .Repository: lightspeed-core/lightspeed-stack Length of output: 50390 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '\n--- .github/dependabot.yml ---\n'
cat -n .github/dependabot.yml
printf '\n--- .github/renovate.json ---\n'
cat -n .github/renovate.json
printf '\n--- workflow action references ---\n'
rg -n --hidden --glob '.github/workflows/*.yaml' 'uses:\s+[^@]+@v[0-9]+' .github/workflows
printf '\n--- pinned SHA references in workflows ---\n'
rg -n --hidden --glob '.github/workflows/*.yaml' 'uses:\s+[^@]+@[0-9a-f]{7,40}' .github/workflowsRepository: lightspeed-core/lightspeed-stack Length of output: 4460 Pin 🧰 Tools🪛 zizmor (1.26.1)[warning] 15-15: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) [error] 15-15: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v5 | ||
| with: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ jobs: | |
| pull-requests: read | ||
| name: "Pyright" | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
# Inspect the workflow around the reported line.
git ls-files .github/workflows/pyright.yaml
cat -n .github/workflows/pyright.yaml | sed -n '1,40p'
# Try to resolve the referenced action tag to a commit SHA, if network/API access is available.
python3 - <<'PY'
import json, urllib.request, urllib.error
url = "https://api.github.com/repos/actions/checkout/git/refs/tags/v7"
req = urllib.request.Request(url, headers={"Accept":"application/vnd.github+json","User-Agent":"CodeRabbit"})
try:
with urllib.request.urlopen(req, timeout=20) as r:
data = json.load(r)
print("REF:", json.dumps(data, indent=2))
except Exception as e:
print("ERROR:", repr(e))
PYRepository: lightspeed-core/lightspeed-stack Length of output: 993 Pin 🧰 Tools🪛 zizmor (1.26.1)[warning] 15-15: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) [error] 15-15: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v5 | ||
| with: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ jobs: | |
| contents: read | ||
| pull-requests: read | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win Version bump is correct; same pinning/persist-credentials gaps as Same pattern as 🧰 Tools🪛 zizmor (1.26.1)[warning] 14-14: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) [error] 14-14: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v5 | ||
| with: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,6 @@ jobs: | |
| contents: read | ||
| pull-requests: read | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win Version bump is correct; same pinning/persist-credentials gaps as Same pattern as 🧰 Tools🪛 zizmor (1.26.1)[warning] 14-14: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) [error] 14-14: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
| - name: Shell check | ||
| run: make shellcheck | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win
Version bump is correct; consider hardening the checkout step.
The
v4→v7bump is valid (v7.0.0 is the current GA release) and matches the PR's stated intent. Static analysis flags two pre-existing gaps on this line worth addressing while touching it: the action isn't pinned to a commit SHA, andpersist-credentials: falseisn't set (credentials otherwise remain in the local git config for the rest of the job).🔒 Suggested hardening
Please verify the exact commit SHA for
v7.0.0before pinning.📝 Committable suggestion
🧰 Tools
🪛 zizmor (1.26.1)
[warning] 14-14: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
[error] 14-14: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)
(unpinned-uses)
🤖 Prompt for AI Agents
Source: Linters/SAST tools