Fix example issue with sbt plugin file.#979
Conversation
| The script is a standard Scala sbt build file--with the addition of the Cloudflow plugin for Akka Streams, the Cloudflow application plugin, and also the Scalafmt plugin that we suggest to keep the style consistent in the application (optional). | ||
| + | ||
| . Create the file `project/cloudflow-plugins.sbt` and add the Cloudflow plugin dependency in it: | ||
| . Create the file `project/cloudflow-plugins.sbt` add logic to get the correct version, and add the Cloudflow plugin dependency: |
There was a problem hiding this comment.
Rather specify the exact version instead of using the lastestVersion trick used to easily work with examples for build.
There was a problem hiding this comment.
Could just inline this piece in antora and use a version variable to template it?
There was a problem hiding this comment.
@RayRoestenburg, I'm not sure how to do this, there is a {cloudflow-version} variable in antora.yml, but the value is set to "dev". I think the build script might change this, but I can't see whether it would end up being the latest version or not? And, should it be latest, or the latest stable version?
There was a problem hiding this comment.
Sorry it is {cloudflow-version}
There was a problem hiding this comment.
(It is an asciidoc attribute)
There was a problem hiding this comment.
I changed it to the variable and committed, but when I build locally, the variable resolves to dev, as you can see below. Can I assume that for production, the build substitutes the correct value?
There was a problem hiding this comment.
correct, place the attribute in quotes and keep just the last line (e.g. addSbtPlugin...) thanks @rstento !
There was a problem hiding this comment.
Done, will do the same for the commercial doc.
RayRoestenburg
left a comment
RayRoestenburg
left a comment
There was a problem hiding this comment.
Prefer to inline the sbt plugins in text and use antora version variable in there.
| [source,scala,subs=attributes+] | ||
| ---- | ||
| include::{cloudflow-examples-version}@docsnippets:ROOT:example$sensor-data-scala/project/cloudflow-plugins.sbt[tag=get-started] | ||
| val latestVersion = { |
…project-configure-build.adoc
3 participants
Fixes #978 and associated issue https://github.com/lightbend/cloudflow-enterprise-docs/issues/53 reported by @jpollock