This repository was archived by the owner on Nov 22, 2024. It is now read-only.
Kubernetes docs#953
Merged
Merged
Conversation
| In this section we are covering the different Kubernetes parameters that are configurable. | ||
|
|
||
| To set the configuration on a container related to Kubernetes is necessary, first of all, to add that configuration under `cloudflow.streamlets.[streamlet-name].kubernetes`. | ||
| On the followint samples we show configurations under a specific streamlet, `my-streamlet`, that in its complete path is `cloudflow.streamlets.my-streamlet`. It is also possible, as explained in xref:develop:cloudflow-configuration.adoc#_configuring_a_runtime_using_the_runtime_scope[Configuring a Runtime using the runtime Scope], to apply any configuration shown in here to any `runtimes`. The complete path for a runtime is, for instance, `cloudflow.runtimes.akka`. |
Contributor
There was a problem hiding this comment.
Suggested change
| On the followint samples we show configurations under a specific streamlet, `my-streamlet`, that in its complete path is `cloudflow.streamlets.my-streamlet`. It is also possible, as explained in xref:develop:cloudflow-configuration.adoc#_configuring_a_runtime_using_the_runtime_scope[Configuring a Runtime using the runtime Scope], to apply any configuration shown in here to any `runtimes`. The complete path for a runtime is, for instance, `cloudflow.runtimes.akka`. | |
| On the following samples we show configurations under a specific streamlet, `my-streamlet`, that in its complete path is `cloudflow.streamlets.my-streamlet`. It is also possible, as explained in xref:develop:cloudflow-configuration.adoc#_configuring_a_runtime_using_the_runtime_scope[Configuring a Runtime using the runtime Scope], to apply any configuration shown in here to any `runtimes`. The complete path for a runtime is, for instance, `cloudflow.runtimes.akka`. |
| To set the configuration on a container related to Kubernetes is necessary, first of all, to add that configuration under `cloudflow.streamlets.[streamlet-name].kubernetes`. | ||
| On the followint samples we show configurations under a specific streamlet, `my-streamlet`, that in its complete path is `cloudflow.streamlets.my-streamlet`. It is also possible, as explained in xref:develop:cloudflow-configuration.adoc#_configuring_a_runtime_using_the_runtime_scope[Configuring a Runtime using the runtime Scope], to apply any configuration shown in here to any `runtimes`. The complete path for a runtime is, for instance, `cloudflow.runtimes.akka`. | ||
|
|
||
| === Resources and Environment Variables |
Contributor
There was a problem hiding this comment.
Please create separate sections for configuring resources and configuring environment variables.
"Configure container resource requests and limits" could be a title for one, "Configure container environment variables" for the other.
| In this section we are covering the different Kubernetes parameters that are configurable. | ||
|
|
||
| To set the configuration on a container related to Kubernetes is necessary, first of all, to add that configuration under `cloudflow.streamlets.[streamlet-name].kubernetes`. | ||
| On the followint samples we show configurations under a specific streamlet, `my-streamlet`, that in its complete path is `cloudflow.streamlets.my-streamlet`. It is also possible, as explained in xref:develop:cloudflow-configuration.adoc#_configuring_a_runtime_using_the_runtime_scope[Configuring a Runtime using the runtime Scope], to apply any configuration shown in here to any `runtimes`. The complete path for a runtime is, for instance, `cloudflow.runtimes.akka`. |
Contributor
There was a problem hiding this comment.
Suggested change
| On the followint samples we show configurations under a specific streamlet, `my-streamlet`, that in its complete path is `cloudflow.streamlets.my-streamlet`. It is also possible, as explained in xref:develop:cloudflow-configuration.adoc#_configuring_a_runtime_using_the_runtime_scope[Configuring a Runtime using the runtime Scope], to apply any configuration shown in here to any `runtimes`. The complete path for a runtime is, for instance, `cloudflow.runtimes.akka`. | |
| In the following examples we show configurations for a specific streamlet named `my-streamlet`, under `cloudflow.streamlets.my-streamlet`. It is also possible, as explained in xref:develop:cloudflow-configuration.adoc#_configuring_a_runtime_using_the_runtime_scope[Configuring a Runtime using the runtime Scope], to apply any configuration shown here to a specific `runtime`. For example, Kubernetes settings for all akka streamlets can be set under`cloudflow.runtimes.akka.kubernetes`. |
RayRoestenburg
left a comment
RayRoestenburg
left a comment
Contributor
There was a problem hiding this comment.
Please accept my suggestions, looks good otherwise.
…w-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com>
Contributor
|
Also please create separate sections for configuring resources and configuring environment variables @franciscolopezsancho better for searching and simpler to read one thing at a time. |
…w-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com>
RayRoestenburg
left a comment
RayRoestenburg
left a comment
Contributor
There was a problem hiding this comment.
Some minor changes to be made, good improvements!
…w-configuration.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com>
…w-configuration.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com>
…w-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com>
…w-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com>
…sing same terms in different places for cohesion
Contributor
Author
|
back at you :) @RayRoestenburg |
RayRoestenburg
left a comment
RayRoestenburg
left a comment
Contributor
There was a problem hiding this comment.
Some final comments!
Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com>
…w-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com>
…w-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com>
…w-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com>
…w-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com>
…w-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com>
…w-configuration-kubernetes.adoc
RayRoestenburg
approved these changes
Jan 20, 2021
RayRoestenburg
added a commit
that referenced
this pull request
Jan 21, 2021
* first commit * reviewing links and content * first draft * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * dividing and conquering * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * accepted changes and cleaned a bit, rephrasing couple of things and using same terms in different places for cohesion * Update docs/docs-source/docs/modules/ROOT/nav.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com> * Update docs/docs-source/docs/modules/develop/pages/streamlet-configuration.adoc * Update docs/shared-content-source/docs/modules/develop/pages/cloudflow-configuration-kubernetes.adoc Co-authored-by: Raymond Roestenburg <raymond.roestenburg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
adding annotation and ports documentation while taking kubernates configuration out of the current page
Why are the changes needed?
to explain the new capabilities and ease the read
Does this PR introduce any user-facing change?
yes the docs
How was this patch tested?
running the local-preview