Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

upgrade to ccpa banner#951

Merged
andreaTP merged 2 commits into
lightbend:masterfrom
rasummer:rasummer/upgrade-to-ccpa-banner
Jan 19, 2021
Merged

upgrade to ccpa banner#951
andreaTP merged 2 commits into
lightbend:masterfrom
rasummer:rasummer/upgrade-to-ccpa-banner

Conversation

@rasummer

Copy link
Copy Markdown
Contributor

@andreaTP this updates the cookie preference center to be ccpa compliant for the docs and the homepage.

screenshot-localhost_8000-2021 01 13-14_28_14

@andreaTP

Copy link
Copy Markdown
Contributor

Sorry I completely missed it @rasummer , thanks!

@andreaTP andreaTP merged commit fbe2d7d into lightbend:master Jan 19, 2021
@andreaTP

Copy link
Copy Markdown
Contributor

@rasummer the new Cookie banner is pretty aggressive in local development, would you, please, reconsider merging/doing something like:
lightbend/antora-ui-lightbend-theme#67
?

@rasummer

Copy link
Copy Markdown
Contributor Author

@rasummer the new Cookie banner is pretty aggressive in local development, would you, please, reconsider merging/doing something like:
lightbend/antora-ui-lightbend-theme#67
?

There is a solution already in place when building the docs locally. As long as you are using a local build that uses the author-mode-site.yml, then it will use the default layout of default-dev. This layout uses the test script and the cookie banner should work normally as long as you are viewing it on a localhost sever such as python -m SimpleHTTPServer. The cookie banner won't work if you just open the file directly in the browser, as it needs to drop a cookie against a domain, thus the need for localhost.

There is one other approach we could look at, one that the Akka Platform guide is doing. In it's case for the html-author-mode make command it is removing and storing the head-scripts.hbs file so that it can build the docs with no cookie banner. It then places the file back in the folder once the local build is complete.

@andreaTP

Copy link
Copy Markdown
Contributor

Thanks for the feedback @rasummer
If it works as expected using localhost is already good enough! Thanks 👍

@rasummer rasummer deleted the rasummer/upgrade-to-ccpa-banner branch January 19, 2021 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants