This repository was archived by the owner on Nov 22, 2024. It is now read-only.
Support for ConfigMap volumes#1114
Merged
Merged
Conversation
leozilla
force-pushed
the
configmap-volumes
branch
from
6b4268f to
aa7665c
Compare
Contributor
|
Thanks for the PR @leozilla , looks like it is going into the right direction! Please see the other export writers, and yes, likely you need to do something extra. It would be great if you could add a test for writing out a config which has config map volumes as well. |
… examples in tests
leozilla
force-pushed
the
configmap-volumes
branch
from
0a4893c to
6310951
Compare
leozilla
commented
Nov 14, 2021
| configMap.getString("name") shouldBe name | ||
| configMap.getBoolean("optional") shouldBe optional | ||
|
|
||
| if (items.nonEmpty) { |
Contributor
Author
There was a problem hiding this comment.
This assertion is a bit ugly, I have not found a nicer way to write it.
RayRoestenburg
approved these changes
Dec 14, 2021
Contributor
|
Thanks @leozilla! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds support for using k8s
ConfigMapfor k8sVolumes. Atm onlySecretandPvcare possible.Why are the changes needed?
See: zulip thread: Why is logging conf stored in a secret instead of ConfigMap
Does this PR introduce any user-facing change?
Yes, it adds a new config feature.
How was this patch tested?
Only tested via unit tests.
Documentation
I did not adjust the documentation yet cos I first want to get some feedback on the PR if this feature makes sense in the way I am proposing it.
Open questions
CloudflowConfigyet and I am pretty sure this will not work at the moment cosexportWritermost likey does not treat theConfigMapVolumeKeyToPathcorrectly. I did only see very few tests for writing theCloudflowConfig, thats why I am wondering if its even necessary?