This repository was archived by the owner on Nov 22, 2024. It is now read-only.
fix: bumping up version#1108
Merged
Merged
Conversation
As per documentation https://github.com/strimzi/strimzi-kafka-operator/releases with the new release the Kafka CR doesn't work no more with version 2.7.1. Deploy a CR with that version raises and exception that states that 2.7.1 is not supported anymore and you need to chose among 2.8.0, 2.8.1 and 3.0.0. I have choosen 3.0.0 only to be the latest, no other reason.
Contributor
|
@franciscolopezsancho do you need any help in testing this change with integration tests before merging it? |
Contributor
Author
|
hey, @andreaTP for some reason I thought the CI would do that. No worries I can test that now. |
Contributor
|
@franciscolopezsancho please run the integration tests to be sure, the CI only runs scripted tests, so it will not hit the strimzi install. (edit, it is now scheduled for a nightly) |
RayRoestenburg
approved these changes
Oct 19, 2021
RayRoestenburg
left a comment
RayRoestenburg
left a comment
Contributor
There was a problem hiding this comment.
LGTM but please test.
Contributor
|
Tested, looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per documentation https://github.com/strimzi/strimzi-kafka-operator/releases with the new release, the Kafka CR doesn't work any more with version 2.7.1. Deploy a CR with that version raises an exception that states that 2.7.1 is not supported anymore and you need to choose among 2.8.0, 2.8.1, and 3.0.0.
I have chosen 3.0.0 only to be the latest, for no other reason.