Move the Protocol version to a secret#1101
Conversation
| case 1 => Success(protocolVersionSecret.get(0)) | ||
| case x if x > 1 => | ||
| Failure( | ||
| CliException("Multiple Cloudflow operators detected in the cluster. This is not supported. Exiting")) |
There was a problem hiding this comment.
It sort of is supported, but only when using operatorNamespace? (maybe specify that they must use the operatorNamespace flag instead?)
| checkCRD(settings, client) | ||
|
|
||
| val ownerReferences = getDeploymentOwnerReferences(settings, client) | ||
| installProtocolVersion(settings, client, ownerReferences) |
There was a problem hiding this comment.
What about adding this to helm chart?
There was a problem hiding this comment.
I guess the cloudflow currently already has permissions to create secrets in its own namespace, so is fine like this too. But feels a bit like a helm thing. (I'm ok what is done here, just a comment)
There was a problem hiding this comment.
make sense, I just restored the old way of doing it, for now, doing it in code makes us faster to change it, but helm makes sense too.
RayRoestenburg
left a comment
RayRoestenburg
left a comment
There was a problem hiding this comment.
One comment about feedback when more than one protocol version is found, if they did not specify the operatorNamespace, we could provide better feedback.
|
fails on format |
2 participants
This change will enable having different Cloudflow versions deployed in separate namespaces in a cluster