This repository was archived by the owner on Nov 22, 2024. It is now read-only.
Fix for VolumeMount API #1072#1073
Merged
Merged
Conversation
ignasi35
approved these changes
Jul 22, 2021
| false, | ||
| (inBytes, throwable) -> { | ||
| context().system().log().error(String.format("an exception occurred on inlet: %s -> (hex string) %h", throwable.getMessage(), inBytes)); | ||
| return Optional.empty(); |
Contributor
There was a problem hiding this comment.
Sneaky change in all that formatting....
Contributor
Author
There was a problem hiding this comment.
sorry about that would have been better as a separate commit.
Added test. Some refactoring, added check for missing volume mounts. Better error message. Cleanup. Fix for compile. Added a comment.
* Cloudflow Custom Resource Definition (CRD). * Comment to remove endpoint statuses from CRD status, not used. * Added docs to CRD fields. * Remove tmp file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes #1072
Added Cloudflow CRD.