This repository was archived by the owner on Nov 22, 2024. It is now read-only.
Added …Inlet.create Java API for errorHandler.#1066
Merged
Conversation
Merged
debasishg
reviewed
Jun 15, 2021
| errorHandler: (Array[Byte], Throwable) => Optional[T]): AvroInlet[T] = | ||
| AvroInlet[T](name, hasUniqueGroupId, (a, t) => { | ||
| val opt = errorHandler(a, t) | ||
| if (opt.isPresent) Some(opt.get()) else None |
Contributor
There was a problem hiding this comment.
Isn't this same as returning the opt itself ?
Contributor
Author
There was a problem hiding this comment.
It's calling the Scala constructor which needs Option, not Optional
debasishg
reviewed
Jun 15, 2021
| errorHandler: (Array[Byte], Throwable) => Optional[T]): ProtoInlet[T] = | ||
| ProtoInlet[T](name, clazz, hasUniqueGroupId, (a, t) => { | ||
| val opt = errorHandler(a, t) | ||
| if (opt.isPresent) Some(opt.get()) else None |
Contributor
There was a problem hiding this comment.
Isn't this same as returning the opt itself ?
Contributor
Author
There was a problem hiding this comment.
Oh no, wait, actually this is converted to the Scala API. The constructor takes Option, not Optional.
debasishg
approved these changes
Jun 15, 2021
debasishg
left a comment
debasishg
left a comment
Contributor
There was a problem hiding this comment.
a minor suggestion .. otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added Java API for ProtoInlet and AvroInlet, for errorHandler.