This repository was archived by the owner on Nov 22, 2024. It is now read-only.
Testkit sink write#1065
Merged
Merged
Conversation
Co-authored-by: thomasschoeftner <Thomas.Schoeftner@gmail.com>
debasishg
reviewed
Jun 15, 2021
| @@ -0,0 +1,97 @@ | |||
| /* | |||
| * Copyright (C) 2016-2020 Lightbend Inc. <https://www.lightbend.com> | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes #1054
#1033
Why are the changes needed?
See referenced issues.
Does this PR introduce any user-facing change?
A
testkitsinkRef.writedoes not cause aCompletedmessage anymore. TheCompletedmessage is only sent when the stream has completed. Internally, everysinkRef.writereturns aFuturethat is completed when the element is written to the Sink.How was this patch tested?
The test that showed the issue is added to the repo, thanks @thomasschoeftner !