Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

The glorious return back to core#1041

Merged
andreaTP merged 27 commits into
masterfrom
back-to-core
May 4, 2021
Merged

The glorious return back to core#1041
andreaTP merged 27 commits into
masterfrom
back-to-core

Conversation

@andreaTP

Copy link
Copy Markdown
Contributor

"Everything must change for everything to remain the same"
Il Gattopardo

TODO:
before this PR gets merged the release process should be tweaked and we should verify that all the artifacts are published as expected.

@debasishg

Copy link
Copy Markdown
Contributor

@andreaTP One general observation. Lots of changes (in fact most of them) comes from scalafmt version and rule changes. It would have been easier to check if these formatting changes were in a separate PR.

@debasishg debasishg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost all of the PR is refactoring code from tools to core and changes in formatting through the new rules and version of scalafmt. LGTM

@andreaTP

andreaTP commented May 3, 2021

Copy link
Copy Markdown
Contributor Author

@debasishg you are right but it would have taken me double the time to keep scalafmt in one commit, unfortunately 😢 sorry.

Minor caveats:

  • cannot get javaformatter to reliably work cross Java 8 - 11 have had to disable it
  • bumped the entire codebase to ScalaTest 3.2 -> this bump is possibly going to break user's tests and they are forced to bump
  • we would need to re-enforce back some scalacOptions.

@andreaTP andreaTP merged commit 401dd62 into master May 4, 2021
@andreaTP andreaTP deleted the back-to-core branch May 4, 2021 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants