This repository was archived by the owner on Nov 22, 2024. It is now read-only.
Fix pod config stacking with empty lists#1036
Merged
Merged
Conversation
Contributor
Author
andreaTP
changed the title
andreaTP
changed the title
Contributor
|
@andreaTP really sry that I didnt had time to review the MR in depth. I just shortly looked over it yesterday but didnt comment anything cos I wanted to take more time. Unfortunately I was super busy the last days. |
Contributor
Author
|
No worries at all @leozilla ! Thanks a lot for your time and dedication! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the order for stacking Configuration of
pod-configWhy are the changes needed?
The specific streamlet config should override the generic runtime
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test