This repository was archived by the owner on Nov 22, 2024. It is now read-only.
Remove the prometheus config map#1031
Merged
Merged
Conversation
RayRoestenburg
left a comment
RayRoestenburg
left a comment
Contributor
There was a problem hiding this comment.
LGTM got a few questions
| --set cloudflow_operator.image.tag=2.0.25-SNAP2-19-ff827053 \ | ||
| --set cloudflow_operator.jvm.opts="-XX:MaxRAMPercentage=90.0 -XX:+UseContainerSupport" \ | ||
| --version "2.0.26-RC15" \ | ||
| --set cloudflow_operator.image.name=andreatp/cloudflow-operator \ |
Contributor
There was a problem hiding this comment.
andreatp? should be lightbend
| jmxExporterJar = agentPaths(PrometheusAgentKey), | ||
| configFile = PrometheusConfig.prometheusConfigPath(Runner.ConfigMapMountPath))) | ||
| SparkApp.Monitoring(prometheus = SparkApp | ||
| .Prometheus(jmxExporterJar = agentPaths(PrometheusAgentKey), configFile = "/prometheus/prometheus.yaml")) |
Contributor
There was a problem hiding this comment.
Do we still need agent paths?
Contributor
There was a problem hiding this comment.
(It would be great if we could get rid of those)
Contributor
There was a problem hiding this comment.
how does this work, pointing to /prometheus/prometheus.yaml?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.