This repository was archived by the owner on Nov 22, 2024. It is now read-only.
Add new saveAppGraph sbt task#1020
Merged
Merged
Conversation
Contributor
Author
|
The tests failed due to inavailability of a Spark driver during the run. So the PR is not a reason. |
andreaTP
suggested changes
Apr 12, 2021
andreaTP
left a comment
andreaTP
left a comment
Contributor
There was a problem hiding this comment.
I made a few suggestions, I like this addition thanks!
Can you please have a scripted test for it to avoid regressions in the future?
Contributor
Author
Did a scripted test that covers both old |
Contributor
Author
|
@andreaTP Hi! |
RayRoestenburg
approved these changes
Apr 15, 2021
andreaTP
approved these changes
Apr 15, 2021
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces a new sbt-task
saveAppGraphwhich allows to save an ASCII blueprint graph visualization to theappGraph.txtfile under the/blueprintfolder.Why are the changes needed?
Sometimes it's handy to see a visualized representation of a given project. Especially in cases when a project contains a lot of streamlets and intermediate kafka topics.
The task can update the file on each compilation, so the visualization would be instantly ready to any team member to explore if needed.
Does this PR introduce any user-facing change?
Yes. It adds a new sbt task.
How was this patch tested?
Was tested locally.