This repository was archived by the owner on Nov 22, 2024. It is now read-only.
Add a flag to disable Flink in the operator#1017
Merged
Merged
Conversation
|
|
||
| private def podReady(ps: App.PodStatus) = { | ||
| ps.status == PodStatus.Running && ps.nrOfContainersReady == ps.nrOfContainers && ps.nrOfContainers > 0 | ||
| (ps.status == PodStatus.Running && ps.nrOfContainersReady == ps.nrOfContainers && ps.nrOfContainers > 0) || (ps.nrOfContainers == 0 && ps.nrOfContainersReady == 0) |
Contributor
There was a problem hiding this comment.
This does not seem right..
Contributor
There was a problem hiding this comment.
IIRC the nrOfContainers can be 0 at first. If this is just for flink status when flink is disabled, rather use the "" marker string to decide this.
| nrOfContainers: Int): App.PodStatus = { | ||
| val ready = | ||
| if (nrOfContainersReady == nrOfContainers && nrOfContainers > 0) PodStatus.ReadyTrue else PodStatus.ReadyFalse | ||
| if ((nrOfContainersReady == nrOfContainers && nrOfContainers > 0)) PodStatus.ReadyTrue else PodStatus.ReadyFalse |
| expectedPodCount = Some(0), | ||
| podStatuses = Seq( | ||
| App.PodStatus( | ||
| name = "<external>", |
Contributor
There was a problem hiding this comment.
why not depend on this "<external>" string to identify the podstatus that should be treated differently?
RayRoestenburg
suggested changes
Apr 8, 2021
RayRoestenburg
left a comment
RayRoestenburg
left a comment
Contributor
There was a problem hiding this comment.
We need to discuss the ready logic.
| private def getStatusFromContainerStates(containerStates: List[ContainerState], nrOfContainers: Int): String = | ||
| if (containerStates.nonEmpty) { | ||
| private def getStatusFromContainerStates(containerStates: List[ContainerState], nrOfContainers: Int): String = { | ||
| if (nrOfContainers == 0) { |
Contributor
There was a problem hiding this comment.
We would prefer to show as pending? not sure about this change.
Contributor
Author
|
should be good to go now @RayRoestenburg |
RayRoestenburg
approved these changes
Apr 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.