Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
==========================================
- Coverage 87.09% 87.09% -0.01%
==========================================
Files 64 64
Lines 2093 2092 -1
Branches 512 511 -1
==========================================
- Hits 1823 1822 -1
Misses 109 109
Partials 161 161 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
URI 5.19 (GH#65) changed query_form so an undef value encoded as a bare "key" (no "="), and a param parsed without "=" decoded to undef. This broke downstream code such as HTTP::Request::Common, which passes undef to mean an empty value, and diverged from the WHATWG URL spec (a param with no "=" decodes to an empty string). Restore the pre-5.19 behavior: - encoding an undef value emits "key=" - a param with no "=" decodes to an empty string, not undef Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133
Problem
URI 5.19 (GH#65, commit 9ee8098) changed
query_formso that:undefvalue produced a barekeywith no=, and=decoded toundef.This broke downstream code such as HTTP::Request::Common (which passes
undefto mean an empty value) and diverged from the WHATWG URL spec, where a param with no=decodes to an empty string. Maintainers in the issue thread confirmed the pre-5.19 behavior was correct.Changes
lib/URI/_query.pm: anundefvalue encodes askey=, and a param with no=decodes to an empty string rather thanundef.t/query.tandt/old-base.tto expect the restored behavior.undef,undefamong multiple values,undefin a hash, and empty-string round-tripping.Testing
prove -lr t/-> 1037 tests, 0 failures.