ci: treat CMake deprecated and development warnings as errors#16008
Merged
Conversation
[sdl-ci-filter *]
madebr
force-pushed
the
ci-cmake-Werror-is-unsupported
branch
from
July 16, 2026 00:45
0f1a968 to
6c1ddec
Compare
Collaborator
|
I think the idea is to fail on all warnings, and if we run into a warning we can't fix, then we exclude that one specifically. |
Collaborator
|
Or is this for CMake and not the compilation itself? |
Contributor
Author
|
This is for CMake only. SDL itself is built with -Werror for practically all platforms. |
Contributor
Author
|
ci is green, so good to merge. |
Contributor
|
I think SDL2 branch needs it too. |
Contributor
Author
Indeed. I removed the |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure we're not using any deprecated feature accidentally (e.g. through CMake toolchain files)
Description
Existing Issue(s)
Fixes #16007