Skip to content

ci: treat CMake deprecated and development warnings as errors#16008

Merged
madebr merged 1 commit into
libsdl-org:mainfrom
madebr:ci-cmake-Werror-is-unsupported
Jul 16, 2026
Merged

ci: treat CMake deprecated and development warnings as errors#16008
madebr merged 1 commit into
libsdl-org:mainfrom
madebr:ci-cmake-Werror-is-unsupported

Conversation

@madebr

@madebr madebr commented Jul 16, 2026

Copy link
Copy Markdown
Contributor
  • I confirm that I am the author of this code and release it to the SDL project under the Zlib license. This contribution does not contain code from other sources, including code generated by a Large Language Model ("AI").

I'm not 100% sure we're not using any deprecated feature accidentally (e.g. through CMake toolchain files)

Description

Existing Issue(s)

Fixes #16007

@madebr
madebr force-pushed the ci-cmake-Werror-is-unsupported branch from 0f1a968 to 6c1ddec Compare July 16, 2026 00:45
@slouken

slouken commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

I think the idea is to fail on all warnings, and if we run into a warning we can't fix, then we exclude that one specifically.

@slouken

slouken commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Or is this for CMake and not the compilation itself?

@madebr

madebr commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

This is for CMake only.

SDL itself is built with -Werror for practically all platforms.
Only powerpc, riscos, ngage and djgpp are not warning-free.

@madebr

madebr commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

ci is green, so good to merge.
See https://github.com/madebr/SDL/actions/runs/29462303599

@madebr
madebr merged commit 64067c1 into libsdl-org:main Jul 16, 2026
10 checks passed
@madebr
madebr deleted the ci-cmake-Werror-is-unsupported branch July 16, 2026 01:50
@sezero

sezero commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

I think SDL2 branch needs it too.

@madebr

madebr commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

I think SDL2 branch needs it too.

Indeed. I removed the -Werror option there.
86a6368

@slouken

slouken commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI MSVC workflows are failing

3 participants