Skip to content

Replaced Scrollable.of with Scrollable.maybeOf #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aryan-more wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replaced Scrollable.of with Scrollable.maybeOf #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions lib/src/widgets/gap.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,18 +71,10 @@ class Gap extends StatelessWidget {

@override
Widget build(BuildContext context) {
ScrollableState? scrollableState;
try {
// TODO: call Scrollable.maybeOf when available on stable.
scrollableState = Scrollable.of(context);
// ignore: avoid_catches_without_on_clauses
} catch (e) {
scrollableState = null;
}
final ScrollableState? scrollableState = Scrollable.maybeOf(context);

final AxisDirection? axisDirection = scrollableState?.axisDirection;
final Axis? fallbackDirection =
axisDirection == null ? null : axisDirectionToAxis(axisDirection);
final Axis? fallbackDirection = axisDirection == null ? null : axisDirectionToAxis(axisDirection);

return _RawGap(
mainAxisExtent,
Expand Down Expand Up @@ -210,8 +202,7 @@ class _RawGap extends LeafRenderObjectWidget {
void debugFillProperties(DiagnosticPropertiesBuilder properties) {
super.debugFillProperties(properties);
properties.add(DoubleProperty('mainAxisExtent', mainAxisExtent));
properties.add(
DoubleProperty('crossAxisExtent', crossAxisExtent, defaultValue: 0));
properties.add(DoubleProperty('crossAxisExtent', crossAxisExtent, defaultValue: 0));
properties.add(ColorProperty('color', color));
properties.add(EnumProperty<Axis>('fallbackDirection', fallbackDirection));
}
Expand Down