Skip to content

Add browser field - #2525

Merged
lukeapage merged 1 commit into
less:masterfrom
wclr:patch-1
Apr 1, 2015
Merged

Add browser field#2525
lukeapage merged 1 commit into
less:masterfrom
wclr:patch-1

Conversation

@wclr

@wclr wclr commented Mar 28, 2015

Copy link
Copy Markdown
Contributor

to support browserfy and other loaders that use browser field for resolving browser version
https://github.com/substack/node-browserify#packagejson

to support browserfy and other loaders that use `browser` field for resolving browser version
https://github.com/substack/node-browserify#packagejson
@lukeapage

Copy link
Copy Markdown
Member

thanks.

lukeapage added a commit that referenced this pull request Apr 1, 2015
@lukeapage
lukeapage merged commit 1e67f03 into less:master Apr 1, 2015
@jonnor

jonnor commented Apr 18, 2015

Copy link
Copy Markdown

I suspect that this actually breaks browserify support...
When depending on less in another project, and there using browserify to bundle my project, I get:

Running "browserify:src" (browserify) task
>> Error: Cannot find module './utils' from '/home/jon/work/thegrid/taylor/node_modules/less/dist'

Not having such problems with 2.4.0

@wclr

wclr commented Apr 18, 2015

Copy link
Copy Markdown
Contributor Author

@jonnor but without it browserfy will require node-version. There is not need parse dist ready browser version There noParse option to skip parsing of require statements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants