Skip to content

[Merged by Bors] - feat(Algebra/ModuleCat): exactness of restrictScalars for general universe level - #39133

Closed
Thmoas-Guan wants to merge 6 commits into
leanprover-community:masterfrom
Thmoas-Guan:restrictScalars-exact
Closed

[Merged by Bors] - feat(Algebra/ModuleCat): exactness of restrictScalars for general universe level#39133
Thmoas-Guan wants to merge 6 commits into
leanprover-community:masterfrom
Thmoas-Guan:restrictScalars-exact

Conversation

@Thmoas-Guan

Copy link
Copy Markdown
Collaborator

Currently exactness of ModuleCat.restrictScalars is synth via being adjoint functor, however this needs the universe level to be some max u v where u is the universe level of the ring. Here we provide exactness of restrictScalars for general universe level using it preserves short exact sequence.


Open in Gitpod

@github-actions

github-actions Bot commented May 10, 2026

Copy link
Copy Markdown

PR summary f394bad6a0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Algebra.Category.ModuleCat.ChangeOfRingsExact (new file) 1368

Declarations diff (regex)

+ ModuleCat.restrictScalars_map_exact
+ instance : Limits.PreservesFiniteColimits (ModuleCat.restrictScalars.{v} f) := by
+ instance : Limits.PreservesFiniteLimits (ModuleCat.restrictScalars.{v} f) := by

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit f394bad).

  • +3 new declarations
  • −0 removed declarations
+ModuleCat.restrictScalars_map_exact
+instPreservesFiniteColimitsModuleCatRestrictScalars
+instPreservesFiniteLimitsModuleCatRestrictScalars

No changes to strong technical debt.

Increase in weak tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type (weak)
4926 1 exposed public sections

Current commit f394bad6a0
Reference commit 97f12126be

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label May 10, 2026
@riccardobrasca

Copy link
Copy Markdown
Member

Can you improve the docstring of the file giving the same explanation as in the PR description? Thanks!

bors d+

@mathlib-bors

mathlib-bors Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

✌️ Thmoas-Guan can now approve this pull request until 2026-06-24 15:35 UTC (in 2 weeks). To approve and merge, reply with bors r+. More detailed instructions are available here.

⚠️ This delegation only covers changes within Archive/**, Counterexamples/**, docs/**, DownstreamTest/**, Mathlib/**, MathlibTest/**, widget/**, Archive.lean, Counterexamples.lean, docs.lean, Mathlib.lean; an author commit touching anything else will revoke it. Bors also revokes it if a later push changes too many files for it to check the full list — even if it stays within scope.

@Thmoas-Guan

Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors Bot pushed a commit that referenced this pull request Jun 11, 2026
…verse level (#39133)

Currently exactness of `ModuleCat.restrictScalars` is synth via being adjoint functor, however this needs the universe level to be some `max u v` where `u` is the universe level of the ring. Here we provide  exactness of restrictScalars for general universe level using it preserves short exact sequence.
@mathlib-bors

mathlib-bors Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(Algebra/ModuleCat): exactness of restrictScalars for general universe level [Merged by Bors] - feat(Algebra/ModuleCat): exactness of restrictScalars for general universe level Jun 11, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 11, 2026
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Jun 13, 2026
…verse level (leanprover-community#39133)

Currently exactness of `ModuleCat.restrictScalars` is synth via being adjoint functor, however this needs the universe level to be some `max u v` where `u` is the universe level of the ring. Here we provide  exactness of restrictScalars for general universe level using it preserves short exact sequence.
ReemMelamed pushed a commit to ReemMelamed/mathlib4 that referenced this pull request Jun 20, 2026
…verse level (leanprover-community#39133)

Currently exactness of `ModuleCat.restrictScalars` is synth via being adjoint functor, however this needs the universe level to be some `max u v` where `u` is the universe level of the ring. Here we provide  exactness of restrictScalars for general universe level using it preserves short exact sequence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants