Skip to content

[Merged by Bors] - chore: enable assert_not_exists in BigOperators - #33187

Closed
Ruben-VandeVelde wants to merge 2 commits into
leanprover-community:masterfrom
Ruben-VandeVelde:enable-assert_not_exists
Closed

[Merged by Bors] - chore: enable assert_not_exists in BigOperators#33187
Ruben-VandeVelde wants to merge 2 commits into
leanprover-community:masterfrom
Ruben-VandeVelde:enable-assert_not_exists

Conversation

@Ruben-VandeVelde

Copy link
Copy Markdown
Contributor

Open in Gitpod

@github-actions

github-actions Bot commented Dec 22, 2025

Copy link
Copy Markdown

PR summary d306471d9a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Dec 22, 2025

@YaelDillies YaelDillies left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

maintainer merge

@YaelDillies YaelDillies added the easy < 20s of review time. See the lifecycle page for guidelines. label Dec 22, 2025
@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 22, 2025
@ocfnash

ocfnash commented Dec 22, 2025

Copy link
Copy Markdown
Contributor

@YaelDillies Can you give some more context here? It looks like this was dropped in #23897?

@YaelDillies

Copy link
Copy Markdown
Contributor

These commented-out assert_not_existss were added by me in #11750 while I was untangling the Algebra, Data and Order folders. They couldn't be uncommented at the time because the multiset library imported basic algebraic order theory. I don't know what exactly has made it possibly to uncomment them now, I didn't think it was (even close to) solved yet. Probably the module system? I don't see what #23897 has to do with anything, it merely split one of the files containing a commented-out assert_not_exists.

@j-loreaux

Copy link
Copy Markdown
Contributor

I don't see any reason not to merge.

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Dec 22, 2025
@mathlib-bors

mathlib-bors Bot commented Dec 22, 2025

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore: enable assert_not_exists in BigOperators [Merged by Bors] - chore: enable assert_not_exists in BigOperators Dec 22, 2025
@mathlib-bors mathlib-bors Bot closed this Dec 22, 2025
kim-em pushed a commit to kim-em/mathlib4 that referenced this pull request Jan 6, 2026
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants