Skip to content

feat: immersions are locally embeddings - #28905

Open
grunweg wants to merge 44 commits into
leanprover-community:masterfrom
grunweg:immersions-locallyembeddings
Open

feat: immersions are locally embeddings#28905
grunweg wants to merge 44 commits into
leanprover-community:masterfrom
grunweg:immersions-locallyembeddings

Conversation

@grunweg

@grunweg grunweg commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

Hopefully, this can be used for the topological portion of #28865. (That part is not certain yet, the rest works.)


Needs some clean-up in both the immersions file, and need to move the helper results about embeddings to the correct location.

Open in Gitpod

@github-actions

github-actions Bot commented Aug 25, 2025

Copy link
Copy Markdown

PR summary 767088cede

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ IsEmbedding.subtype_map_of_subset
+ _root_.Topology.IsEmbedding.comp_restrict
+ isClosedEmbedding_symm_restrict
+ isEmbedding_extend_restrict
+ isEmbedding_extend_symm_restrict
+ isEmbedding_restr_domChart_source
+ isEmbedding_symm_restrict
+ rightInverse_restrict
++ eqOn_domChart_source
++ exists_nbhd_restr_isEmbedding

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 767088cede
Reference commit 433572dde7

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 25, 2025
@grunweg
grunweg force-pushed the immersions-locallyembeddings branch from fcc5d4d to 8e35b1c Compare August 28, 2025 09:45
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 8, 2025
@mathlib4-merge-conflict-bot

Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@grunweg
grunweg force-pushed the immersions-locallyembeddings branch from abf0809 to 28ba7ba Compare December 18, 2025 16:51
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 18, 2025
@grunweg grunweg added the t-differential-geometry Manifolds etc label Jan 12, 2026
@mathlib4-merge-conflict-bot

Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 18, 2026
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 10, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jun 10, 2026
@mathlib-dependent-issues

Copy link
Copy Markdown

@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 19, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants