Skip to content

[Merged by Bors] - feat: add IsEmbedding.sumElim_of_separatingNhds - #26099

Closed
grunweg wants to merge 7 commits into
leanprover-community:masterfrom
grunweg:MR-isInducing-sumElim
Closed

[Merged by Bors] - feat: add IsEmbedding.sumElim_of_separatingNhds#26099
grunweg wants to merge 7 commits into
leanprover-community:masterfrom
grunweg:MR-isInducing-sumElim

Conversation

@grunweg

@grunweg grunweg commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

Characterise when the Sum.elim of two inducing maps resp. embeddings is an embedding,
and deduce that the ranges of the two maps lying in separated neighbourhoods suffices.

This is used in my bordism theory project.

Co-authored by: @plp127


This PR was manually re-created (and migrated to a fork at the same time) from #22137, since that seemed easiest.

Open in Gitpod

@grunweg grunweg added t-topology Topological spaces, uniform spaces, metric spaces, filters new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! labels Jun 18, 2025
@github-actions

github-actions Bot commented Jun 18, 2025

Copy link
Copy Markdown

PR summary 9a749a69c4

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Topology.Constructions.SumProd 592 594 +2 (+0.34%)
Import changes for all files
Files Import difference
48 files Mathlib.Data.Analysis.Topology Mathlib.Dynamics.TopologicalEntropy.DynamicalEntourage Mathlib.MeasureTheory.Constructions.Cylinders Mathlib.Topology.AlexandrovDiscrete Mathlib.Topology.Algebra.Indicator Mathlib.Topology.Bases Mathlib.Topology.Clopen Mathlib.Topology.Coherent Mathlib.Topology.Compactness.Bases Mathlib.Topology.Compactness.Compact Mathlib.Topology.Compactness.CompactlyCoherentSpace Mathlib.Topology.Compactness.Exterior Mathlib.Topology.Compactness.Lindelof Mathlib.Topology.Compactness.LocallyCompact Mathlib.Topology.Compactness.LocallyFinite Mathlib.Topology.Compactness.NhdsKer Mathlib.Topology.Compactness.SigmaCompact Mathlib.Topology.Connected.Basic Mathlib.Topology.Connected.Clopen Mathlib.Topology.Connected.LocallyConnected Mathlib.Topology.Connected.TotallyDisconnected Mathlib.Topology.Constructions Mathlib.Topology.ContinuousOn Mathlib.Topology.EMetricSpace.Defs Mathlib.Topology.Exterior Mathlib.Topology.Hom.ContinuousEvalConst Mathlib.Topology.Hom.ContinuousEval Mathlib.Topology.Inseparable Mathlib.Topology.Irreducible Mathlib.Topology.List Mathlib.Topology.LocallyClosed Mathlib.Topology.LocallyFinite Mathlib.Topology.MetricSpace.BundledFun Mathlib.Topology.MetricSpace.Congruence Mathlib.Topology.MetricSpace.Defs Mathlib.Topology.MetricSpace.MetricSeparated Mathlib.Topology.MetricSpace.Pseudo.Defs Mathlib.Topology.MetricSpace.Similarity Mathlib.Topology.NhdsKer Mathlib.Topology.Order.LeftRight Mathlib.Topology.Order.LocalExtr Mathlib.Topology.Order.Priestley Mathlib.Topology.Piecewise Mathlib.Topology.PreorderRestrict Mathlib.Topology.UniformSpace.Basic Mathlib.Topology.UniformSpace.Compact Mathlib.Topology.UniformSpace.DiscreteUniformity Mathlib.Topology.UniformSpace.Ultra.Basic
1
5 files Mathlib.Topology.Algebra.ContinuousMonoidHom Mathlib.Topology.Algebra.Group.Defs Mathlib.Topology.Algebra.Monoid.Defs Mathlib.Topology.Constructions.SumProd Mathlib.Topology.FiberBundle.IsHomeomorphicTrivialBundle
2

Declarations diff

+ IsInducing.sumSwap
+ IsOpenEmbedding.sumSwap
+ Topology.IsEmbedding.sumElim
+ Topology.IsEmbedding.sumElim_left
+ Topology.IsEmbedding.sumElim_of_separatedNhds
+ Topology.IsEmbedding.sumElim_right
+ Topology.IsInducing.disjoint_of_sumElim_aux
+ Topology.IsInducing.sumElim
+ Topology.IsInducing.sumElim_left
+ Topology.IsInducing.sumElim_of_separatedNhds
+ Topology.IsInducing.sumElim_right
+ elim_swap
+ isEmbedding_sumElim
+ isInducing_sumElim

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Comment thread Mathlib/Topology/Constructions/SumProd.lean Outdated
Comment thread Mathlib/Topology/Constructions/SumProd.lean Outdated
Comment thread Mathlib/Topology/Constructions/SumProd.lean Outdated
grunweg and others added 3 commits July 25, 2025 15:05
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
@grunweg

grunweg commented Jul 29, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for the golfs! This is ready for review again.

@ADedecker ADedecker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

Comment thread Mathlib/Topology/Constructions/SumProd.lean Outdated
@github-actions

github-actions Bot commented Aug 3, 2025

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by ADedecker.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 3, 2025
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
@PatrickMassot

Copy link
Copy Markdown
Member

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Aug 4, 2025
mathlib-bors Bot pushed a commit that referenced this pull request Aug 4, 2025
Characterise when the Sum.elim of two inducing maps resp. embeddings is an embedding,
and deduce that the ranges of the two maps lying in separated neighbourhoods suffices.

This is used in my bordism theory project.

Co-authored by: @plp127
@mathlib-bors

mathlib-bors Bot commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Build failed (retrying...):

@bryangingechen

Copy link
Copy Markdown
Contributor

bors r+

mathlib-bors Bot pushed a commit that referenced this pull request Aug 4, 2025
Characterise when the Sum.elim of two inducing maps resp. embeddings is an embedding,
and deduce that the ranges of the two maps lying in separated neighbourhoods suffices.

This is used in my bordism theory project.

Co-authored by: @plp127
@mathlib-bors

mathlib-bors Bot commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Build failed:

Comment thread Mathlib/Topology/Constructions/SumProd.lean Outdated
@bryangingechen

Copy link
Copy Markdown
Contributor

Thanks!
bors d+

@mathlib-bors

mathlib-bors Bot commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Aug 4, 2025
@grunweg

grunweg commented Aug 4, 2025

Copy link
Copy Markdown
Contributor Author

CI passes, so let's try again
bors merge

@bryangingechen

Copy link
Copy Markdown
Contributor

This fell off the queue
bors r+

@bryangingechen

Copy link
Copy Markdown
Contributor

bors r+

mathlib-bors Bot pushed a commit that referenced this pull request Aug 4, 2025
Characterise when the Sum.elim of two inducing maps resp. embeddings is an embedding,
and deduce that the ranges of the two maps lying in separated neighbourhoods suffices.

This is used in my bordism theory project.

Co-authored by: @plp127
@mathlib-bors

mathlib-bors Bot commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat: add IsEmbedding.sumElim_of_separatingNhds [Merged by Bors] - feat: add IsEmbedding.sumElim_of_separatingNhds Aug 4, 2025
@mathlib-bors mathlib-bors Bot closed this Aug 4, 2025
@grunweg
grunweg deleted the MR-isInducing-sumElim branch August 5, 2025 07:31
@grunweg

grunweg commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

Thank you for the reviews, and the patient help with re-borsing.

Equilibris pushed a commit to Equilibris/mathlib4 that referenced this pull request Aug 7, 2025
…#26099)

Characterise when the Sum.elim of two inducing maps resp. embeddings is an embedding,
and deduce that the ranges of the two maps lying in separated neighbourhoods suffices.

This is used in my bordism theory project.

Co-authored by: @plp127
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
…#26099)

Characterise when the Sum.elim of two inducing maps resp. embeddings is an embedding,
and deduce that the ranges of the two maps lying in separated neighbourhoods suffices.

This is used in my bordism theory project.

Co-authored by: @plp127
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
…#26099)

Characterise when the Sum.elim of two inducing maps resp. embeddings is an embedding,
and deduce that the ranges of the two maps lying in separated neighbourhoods suffices.

This is used in my bordism theory project.

Co-authored by: @plp127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants