[Merged by Bors] - chore(Topology/Constructions): tweak and move Prod.instNeBotNhdsWithinIoi - #22844
Closed
grunweg wants to merge 3 commits into
Closed
[Merged by Bors] - chore(Topology/Constructions): tweak and move Prod.instNeBotNhdsWithinIoi#22844grunweg wants to merge 3 commits into
Prod.instNeBotNhdsWithinIoi#22844grunweg wants to merge 3 commits into
Conversation
PR summary ca0d7b456eImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
github-actions
Bot
added
the
t-topology
- tweak the proof of Prod.instNeBotNhdsWithinIoi; this does not actually require the order dual, hence can also go into Constructions.SumProd. - when fixing the merge conflict with #22670, I re-applied the changes to Constructions.lean locally, but forgot to push them. Here they are.
grunweg
force-pushed
the
MR-constructions-sumprod-fixup
branch
from
March 11, 2025 18:00
51a1c0e to
5c3c00b
Compare
jcommelin
reviewed
Mar 13, 2025
grunweg
commented
Mar 13, 2025
grunweg
commented
Mar 13, 2025
Contributor
Author
|
This PR will conflict with #22195; let's get that PR in first. |
leanprover-community-bot-assistant
added
the
merge-conflict
github-actions
Bot
removed
the
merge-conflict
grunweg
changed the title
Prod.instNeBotNhdsWithinIoi
Contributor
Author
|
This PR is now just moving an instance, hence ready for re-review. |
Member
|
Thanks! 🎉 |
ghost
added
the
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
Prod.instNeBotNhdsWithinIoiProd.instNeBotNhdsWithinIoi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not actually require the order dual, hence can also go into Constructions.SumProd. Follow-up to #22827.