[Merged by Bors] - chore: renaming and documentation for NumberField.FinitePlace

[smmercuri]

---

[github-actions]

PR summary 50cad6ccec

Import changes for modified files

No significant changes to the import graph

Import changes for all files

Files	Import difference

---

Declarations diff

+ FinitePlace.embedding
+ FinitePlace.norm_eq_one_iff_not_mem
+ FinitePlace.norm_le_one
+ FinitePlace.norm_lt_one_iff_mem
+ RingOfIntegers.HeightOneSpectrum.adicAbv_add_le_max
+ RingOfIntegers.HeightOneSpectrum.adicAbv_intCast_le_one
+ RingOfIntegers.HeightOneSpectrum.adicAbv_natCast_le_one
+ absNorm_ne_zero
+ adicAbv
+ adicAbv_def
+ mk_apply
+ one_lt_absNorm
+ one_lt_absNorm_nnreal
- norm_eq_one_iff_not_mem
- vadicAbv_add_le_max
- vadicAbv_intCast_le_one
- vadicAbv_natCast_le_one

You can run this locally as follows

## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

---

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary

• The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
• The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

[YaelDillies]

Can you run scripts/add_deprecations.sh?

[smmercuri]

Can you run scripts/add_deprecations.sh?

Deprecations added!

[YaelDillies]

Looks all good to me! Can a number theori st check the names?

maintainer merge?

[github-actions]

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

[faenuccio]

@YaelDillies I guess that your question mark after the maintainer merge was supposed to ask for approval but bors took it for a proper call, right? Of course, I am not claiming anything was wrong (and I am checking the names), just perhaps a small problem with bors.

[faenuccio]

Modulo a minor question about two injectivity lemmas that got deleted, it is all good.

[Ruben-VandeVelde]

Definitely don't remove any lemma that hasn't been deprecated first.

(The main-tainer merge syntax with question mark is a feature: it adds the question to the zulip message)

[smmercuri]

Definitely don't remove any lemma that hasn't been deprecated first.

(The main-tainer merge syntax with question mark is a feature: it adds the question to the zulip message)

Thanks, added those back in now

[kbuzzard]

Thanks!

bors merge

[mathlib-bors]

Pull request successfully merged into master.

Build succeeded:

• Build
• Lint style