[Merged by Bors] - chore(CategoryTheory): turn more simp into simps! - #22223
Closed
robin-carlier wants to merge 2 commits into
Closed
[Merged by Bors] - chore(CategoryTheory): turn more simp into simps!#22223robin-carlier wants to merge 2 commits into
simp into simps!#22223robin-carlier wants to merge 2 commits into
Conversation
PR summary 6be2755a96Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Contributor
|
Thanks! bors merge |
ghost
added
the
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Feb 23, 2025
Turn some possibly mistaken `simp` attributes on definitions of isomorphisms into `simps`. In some cases, the projections were already recorded as `simp` lemmas, so the attribute was simply removed. Note: as it seems some things were relying on the definitional properties of `Functor.mapBiprod` and `Functor.mapBiproduct`, removing their `simp` attribute require turning them into abbrev.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
simp into simps!simp into simps!
Julian
added a commit
that referenced
this pull request
Feb 24, 2025
* origin/master: feat(Polynomial): polynomial sequences are bases for R[X] (#20846) feat: monoidal structure on Hopf algebras (#12011) feat(DiscreteValuationRing): addVal_eq_zero_iff (#21154) refactor(Cache): refactor getPackageDir to not use manually provided package directories (#21817) feat(CategoryTheory): categories of homological complexes have a separator (#20229) chore(Data/Complex): deprecate `Complex.abs` (#21995) feat: uncountable instances for `Ordinal` and isomorphic types (#18547) feat(Data/Set/Card): a few missing lemmas (#22186) feat: discrete topological spaces are 0-manifolds (#22105) feat(Data/Matroid/Loop): matroid loops (#22045) feat(SetTheory/Ordinal/Nimber/Field): Nimber division (#19066) feat(LinearAlgebra/Pi): add `pi_proj` and `pi_proj_comp` (#22162) feat(Data/Matroid/Circuit): matroid cocircuits (#21692) feat(Topology/Compactification/OnePoint): generalize instance (#22179) feat(Combinatorics/SimpleGraph): takeUntil properties (#21250) feat(Tactic): `pnat_to_nat` and `enat_to_nat` tactics (#21602) refactor: move `Polynomial.coeffs` and related results (#22225) chore: add AlgHom.ker_coe_equiv, resolve porting notes and erws (#22019) refactor(Order/Category): `ConcreteCategory` instance for `\omegaCPO` (#21478) feat(CategoryTheory): Grothendieck categories have a coseparator (#22224) feat: tweak calc widget (#22170) feat(CategoryTheory): the Freyd-Mitchell embedding theorem (#22222) chore(CategoryTheory): turn more `simp` into `simps!` (#22223) feat(CategoryTheory): the category of ind-objects is Grothendieck abelian (#21606) feat(AlgebraicTopology/SimplexCategory/GeneratorsRelations/EpiMono): epi-mono factorisation in `SimplexCategoryGenRel` (#21743) chore(CategoryTheory/DiscreteCategory): turn `simp` to `simps!` (#22217) feat(Analysis/Asymptotics): exponential growth of a sequence (#21178) feat(CategoryTheory): sigmaConst preserves monomorphisms (#21599) feat(RingTheory/Cotangent): `liftBaseChange` is injective for localizations (#21037) chore(CategoryTheory): fix incorrect name (#22210) feat(CategoryTheory): `IsPullback` version of 'pullback of iso is iso' (#22211) feat(CategoryTheory): pullbacks in functor categories (#22209) feat(CategoryTheory): detecting limit cones over connected diagrams (#22192) feat(LinearAlgebra): add theorems for injective/surjective/bijective compositions of bilinear maps (#21491)
Champitoad
pushed a commit
that referenced
this pull request
Feb 25, 2025
Turn some possibly mistaken `simp` attributes on definitions of isomorphisms into `simps`. In some cases, the projections were already recorded as `simp` lemmas, so the attribute was simply removed. Note: as it seems some things were relying on the definitional properties of `Functor.mapBiprod` and `Functor.mapBiproduct`, removing their `simp` attribute require turning them into abbrev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turn some possibly mistaken
simpattributes on definitions of isomorphisms intosimps. In some cases, the projections were already recorded assimplemmas, so the attribute was simply removed.Note: as it seems some things were relying on the definitional properties of
Functor.mapBiprodandFunctor.mapBiproduct, removing theirsimpattribute require turning them into abbrev.