Skip to content

[Merged by Bors] - chore(DedekindDomain/AdicCompletion): generalise algebra instance to separate rings - #21301

Closed
YaelDillies wants to merge 4 commits into
masterfrom
dedekind_domain_adic_completion_general_smul
Closed

[Merged by Bors] - chore(DedekindDomain/AdicCompletion): generalise algebra instance to separate rings#21301
YaelDillies wants to merge 4 commits into
masterfrom
dedekind_domain_adic_completion_general_smul

Conversation

@YaelDillies

@YaelDillies YaelDillies commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

This is analogous to #19466.

From FLT

Open in Gitpod

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Jan 31, 2025
@github-actions

github-actions Bot commented Jan 31, 2025 •
edited
Loading

Copy link
Copy Markdown

PR summary f62b8b443a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance : Algebra S (v.adicCompletion K)
+ instance : IsScalarTower S K (v.adicCompletion K) := inferInstanceAs <|
- adicCompletion.algebra'
- algebraMap_adicCompletion'
- instance : IsScalarTower R K (v.adicCompletion K) := inferInstanceAs <|
-- instance : Algebra K (v.adicCompletion K)

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@YaelDillies YaelDillies mentioned this pull request Jan 31, 2025
Closed
Ruben-VandeVelde
Ruben-VandeVelde reviewed Feb 2, 2025
View reviewed changes
Comment thread Mathlib/RingTheory/DedekindDomain/AdicValuation.lean Outdated
@YaelDillies @Ruben-VandeVelde
I am vindicated
e381a12 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
riccardobrasca
riccardobrasca approved these changes Feb 14, 2025
View reviewed changes

@riccardobrasca riccardobrasca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

bors d+

Comment thread Mathlib/RingTheory/DedekindDomain/AdicValuation.lean Outdated
Comment thread Mathlib/RingTheory/DedekindDomain/AdicValuation.lean

variable (K)

-- TODO: We would be fighting Lean in this section a lot less if "`K` equipped with its `v`-adic

@riccardobrasca riccardobrasca Feb 14, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smmercuri This is very similar to your WithAbs, right? What do you think?

@smmercuri smmercuri Feb 17, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I just saw this. I have also been thinking of something similar. I actually have an old branch where I played around with a WithValuation type synonym for this purpose. If people think it's useful I could PR it!

@YaelDillies YaelDillies Feb 17, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please!

@mathlib-bors

mathlib-bors Bot commented Feb 14, 2025

Copy link
Copy Markdown
Contributor

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Feb 14, 2025
@YaelDillies

YaelDillies commented Feb 14, 2025

Copy link
Copy Markdown
Contributor Author

bors merge

mathlib-bors Bot pushed a commit that referenced this pull request Feb 14, 2025
@YaelDillies
chore(DedekindDomain/AdicCompletion): generalise algebra instance to …
a4c3330 
…separate rings (#21301)

This is analogous to #19466.

From FLT
@mathlib-bors

mathlib-bors Bot commented Feb 14, 2025

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(DedekindDomain/AdicCompletion): generalise algebra instance to separate rings [Merged by Bors] - chore(DedekindDomain/AdicCompletion): generalise algebra instance to separate rings Feb 14, 2025
@mathlib-bors mathlib-bors Bot closed this Feb 14, 2025
@mathlib-bors
mathlib-bors Bot deleted the dedekind_domain_adic_completion_general_smul branch February 14, 2025 15:19
@smmercuri smmercuri mentioned this pull request Feb 18, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde left review comments
@riccardobrasca riccardobrasca riccardobrasca approved these changes
+1 more reviewer
@smmercuri smmercuri smmercuri left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@YaelDillies @riccardobrasca @smmercuri @Ruben-VandeVelde