Skip to content

[Merged by Bors] - feat(RingTheory/Presentation): reindex presentations - #21260

Closed
chrisflav wants to merge 8 commits into
masterfrom
chrisflav-standardsmooth-universes
Closed

[Merged by Bors] - feat(RingTheory/Presentation): reindex presentations#21260
chrisflav wants to merge 8 commits into
masterfrom
chrisflav-standardsmooth-universes

Conversation

@chrisflav

@chrisflav chrisflav commented Jan 30, 2025

Copy link
Copy Markdown
Member

Constructs induced presentations from equivalent indexing types for generators and relations. This will be used in a follow-up to fix the universes of the generators and relations in Algebra.IsStandardSmooth to 0.


Open in Gitpod

@chrisflav chrisflav added the t-algebra Algebra (groups, rings, fields, etc) label Jan 30, 2025
@github-actions

github-actions Bot commented Jan 30, 2025

Copy link
Copy Markdown

PR summary e46d00e575

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsFinite.reindex
+ _
+ comap_idₐ
+ isFinite_reindex_iff
+ jacobiMatrix_reindex
+ jacobian_reindex
+ map_idₐ
+ reindex_val
++++ reindex

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jan 30, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 20, 2025
@mathlib4-dependent-issues-bot

Copy link
Copy Markdown
Collaborator

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 20, 2025
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 22, 2025
Comment thread Mathlib/RingTheory/Generators.lean Outdated
Comment thread Mathlib/RingTheory/Presentation.lean
@erdOne erdOne added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 31, 2025
@chrisflav chrisflav added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Mar 31, 2025
@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Mar 31, 2025
@erdOne

erdOne commented Mar 31, 2025

Copy link
Copy Markdown
Member

Thanks!
maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by erdOne.

@github-actions github-actions Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 31, 2025
@riccardobrasca

Copy link
Copy Markdown
Member

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Mar 31, 2025
mathlib-bors Bot pushed a commit that referenced this pull request Mar 31, 2025
Constructs induced presentations from equivalent indexing types for generators and relations. This will be used in a follow-up to fix the universes of the generators and relations in `Algebra.IsStandardSmooth` to `0`.
@mathlib-bors

mathlib-bors Bot commented Mar 31, 2025

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(RingTheory/Presentation): reindex presentations [Merged by Bors] - feat(RingTheory/Presentation): reindex presentations Mar 31, 2025
@mathlib-bors mathlib-bors Bot closed this Mar 31, 2025
@mathlib-bors
mathlib-bors Bot deleted the chrisflav-standardsmooth-universes branch March 31, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants