feat(Algebra/Category/Ring): replace HasForget with ConcreteCategory - #20826
Closed
Vierkantor wants to merge 1 commit into
Closed
feat(Algebra/Category/Ring): replace HasForget with ConcreteCategory#20826Vierkantor wants to merge 1 commit into
HasForget with ConcreteCategory#20826Vierkantor wants to merge 1 commit into
Conversation
This changes nothing about the definition of ring categories except upgrading the `HasForget` instance to `ConcreteCategory`. This PR is intended mostly as an experiment to contrast with #20815 and figure out why that one has a disappointing benchmark outcome.
PR summary 99bae9437fImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 99bae94. Benchmark Metric Change
==================================================================================
- ~Mathlib.Algebra.Category.ModuleCat.Differentials.Presheaf instructions 64.5%
- ~Mathlib.Algebra.Category.ModuleCat.Presheaf.Monoidal instructions 24.6%
- ~Mathlib.Algebra.Category.Ring.Limits instructions 41.4%
+ ~Mathlib.AlgebraicGeometry.AffineScheme instructions -12.5%
- ~Mathlib.AlgebraicGeometry.Modules.Tilde instructions 6.6%
+ ~Mathlib.AlgebraicGeometry.OpenImmersion instructions -41.7%
+ ~Mathlib.AlgebraicGeometry.Spec instructions -23.4%
+ ~Mathlib.AlgebraicGeometry.StructureSheaf instructions -32.6%
+ ~Mathlib.Geometry.Manifold.Sheaf.Smooth instructions -43.2%
+ ~Mathlib.Geometry.RingedSpace.OpenImmersion instructions -10.8% |
2 files, Instructions +2.0⬝10⁹
6 files, Instructions +1.0⬝10⁹
2 files, Instructions -31.0⬝10⁹
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes nothing about the definition of ring categories except upgrading the
HasForgetinstance toConcreteCategory. This PR is intended mostly as an experiment to contrast with #20815 and figure out why that one has a disappointing benchmark outcome.