Skip to content

[Merged by Bors] - chore(SetTheory/Cardinal/Basic): move IsStrongLimit - #19723

Closed
vihdzp wants to merge 18 commits into
masterfrom
vi.stronglimit
Closed

[Merged by Bors] - chore(SetTheory/Cardinal/Basic): move IsStrongLimit#19723
vihdzp wants to merge 18 commits into
masterfrom
vi.stronglimit

Conversation

@vihdzp

@vihdzp vihdzp commented Dec 4, 2024

Copy link
Copy Markdown
Collaborator

This definition doesn't rely on cofinality in any way.


Arguably the Cardinal/Basic file is getting too long, but it seems excessively fragmentary to move IsStrongLimit into its own file.

Open in Gitpod

@vihdzp vihdzp added the t-set-theory Set theory label Dec 4, 2024
@github-actions

github-actions Bot commented Dec 4, 2024

Copy link
Copy Markdown

PR summary d9296768ec

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 5, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 8, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 7, 2025
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 17, 2025
@vihdzp
vihdzp requested a review from YaelDillies February 17, 2025 04:18
@vihdzp vihdzp closed this Feb 17, 2025
@vihdzp vihdzp reopened this Feb 17, 2025
@vihdzp
vihdzp removed the request for review from YaelDillies February 17, 2025 04:36
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 17, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 20, 2025
@mathlib4-dependent-issues-bot

Copy link
Copy Markdown
Collaborator

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 20, 2025
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 22, 2025

@YaelDillies YaelDillies left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Are you eventually planning to split Cardinal.Basic?

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Feb 22, 2025
@vihdzp

vihdzp commented Feb 23, 2025

Copy link
Copy Markdown
Collaborator Author

Yeah, it's one of the many things I plan to eventually get to.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 4, 2025
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 6, 2025
@kim-em

kim-em commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

bors merge

mathlib-bors Bot pushed a commit that referenced this pull request Mar 6, 2025
This definition doesn't rely on cofinality in any way.
@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Mar 6, 2025
@mathlib-bors

mathlib-bors Bot commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(SetTheory/Cardinal/Basic): move IsStrongLimit [Merged by Bors] - chore(SetTheory/Cardinal/Basic): move IsStrongLimit Mar 6, 2025
@mathlib-bors mathlib-bors Bot closed this Mar 6, 2025
@mathlib-bors
mathlib-bors Bot deleted the vi.stronglimit branch March 6, 2025 22:35
Paul-Lez pushed a commit that referenced this pull request Mar 7, 2025
This definition doesn't rely on cofinality in any way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-set-theory Set theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants