[Merged by Bors] - chore(SetTheory/Cardinal/Basic): move IsStrongLimit - #19723
Closed
vihdzp wants to merge 18 commits into
Closed
[Merged by Bors] - chore(SetTheory/Cardinal/Basic): move IsStrongLimit#19723vihdzp wants to merge 18 commits into
IsStrongLimit#19723vihdzp wants to merge 18 commits into
Conversation
PR summary d9296768ecImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
This was referenced Feb 17, 2025
Collaborator
|
This PR/issue depends on: |
YaelDillies
approved these changes
Feb 22, 2025
YaelDillies
left a comment
Contributor
There was a problem hiding this comment.
maintainer merge
Are you eventually planning to split Cardinal.Basic?
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Collaborator
Author
|
Yeah, it's one of the many things I plan to eventually get to. |
Contributor
|
bors merge |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
This definition doesn't rely on cofinality in any way.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
IsStrongLimitIsStrongLimit
Paul-Lez
pushed a commit
that referenced
this pull request
Mar 7, 2025
This definition doesn't rely on cofinality in any way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This definition doesn't rely on cofinality in any way.
IsStrongLimitinto a structure #21971Arguably the
Cardinal/Basicfile is getting too long, but it seems excessively fragmentary to moveIsStrongLimitinto its own file.