[Merged by Bors] - chore(NumberTheory/Harmonic): shake imports - #18158
Closed
Vierkantor wants to merge 1 commit into
Closed
[Merged by Bors] - chore(NumberTheory/Harmonic): shake imports#18158Vierkantor wants to merge 1 commit into
Vierkantor wants to merge 1 commit into
Conversation
This file seems to contain many unused imports. Some of them were around from the start of the file, and some were added in #11750 for reasons I don't entirely understand. (Context: I'm checking which `Defs.lean` files actually only provide definitions.)
Vierkantor
added
the
t-number-theory
PR summary 119949e7c0
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.NumberTheory.Harmonic.Defs | 702 | 683 | -19 (-2.71%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.NumberTheory.Harmonic.Defs |
-19 |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
YaelDillies
approved these changes
Oct 24, 2024
YaelDillies
left a comment
YaelDillies
left a comment
Contributor
There was a problem hiding this comment.
shake was acting unreliably in #11750 so I had to do things manually in places, and clearly I got it wrong!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
github-actions
Bot
added
the
maintainer-merge
Contributor
|
bors r+ |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
This file seems to contain many unused imports. Some of them were around from the start of the file, and some were added in #11750 for reasons I don't entirely understand. (Context: I'm checking which `Defs.lean` files actually only provide definitions.)
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file seems to contain many unused imports. Some of them were around from the start of the file, and some were added in #11750 for reasons I don't entirely understand.
(Context: I'm checking which
Defs.leanfiles actually only provide definitions.)